Skip to content

Commit

Permalink
Fix feature count for categorized renderer (NULLs)
Browse files Browse the repository at this point in the history
Fixes #45280

Backported from master #45361
  • Loading branch information
elpaso authored and nyalldawson committed Oct 6, 2021
1 parent 7892990 commit 08a42b7
Showing 1 changed file with 33 additions and 0 deletions.
33 changes: 33 additions & 0 deletions tests/src/python/test_qgsrulebasedrenderer.py
Expand Up @@ -456,6 +456,39 @@ def testPointsUsedAttributes(self):

QgsProject.instance().removeMapLayer(points_layer)

def testNullsCount(self):
"""Test for issue GH #45280"""

vl = QgsVectorLayer('Point?crs=epsg:4326&field=number:int',
'test', 'memory')

f = QgsFeature(vl.fields())
f.setAttribute(0, 0)
f.setGeometry(QgsGeometry.fromWkt('point(7 45)'))
vl.dataProvider().addFeatures([f])
f = QgsFeature(vl.fields())
f.setGeometry(QgsGeometry.fromWkt('point(7 45)'))
f.setAttribute(0, 1)
vl.dataProvider().addFeatures([f])
f.setGeometry(QgsGeometry.fromWkt('point(7 45)'))
f = QgsFeature(vl.fields())
vl.dataProvider().addFeatures([f])

cats = []
cats.append(QgsRendererCategory(1, QgsMarkerSymbol(), 'one'))
cats.append(QgsRendererCategory(0, QgsMarkerSymbol(), 'zero'))
cats.append(QgsRendererCategory(None, QgsMarkerSymbol(), 'NULL'))
renderer = QgsCategorizedSymbolRenderer("number", cats)

vl.setRenderer(renderer)

counter = vl.countSymbolFeatures()
counter.waitForFinished()

self.assertEqual(counter.featureCount('0'), 1)
self.assertEqual(counter.featureCount('1'), 1)
self.assertEqual(counter.featureCount('2'), 1)


if __name__ == '__main__':
unittest.main()

0 comments on commit 08a42b7

Please sign in to comment.