Revert "Avoid type quotation errors in value exists check"

m-kuhn · m-kuhn · commit 08443c20d894 · 2017-10-20T17:11:32.000+02:00
This reverts commit 6ce4b60.
diff --git a/src/core/qgsvectorlayerutils.cpp b/src/core/qgsvectorlayerutils.cpp
@@ -22,12 +22,12 @@ bool QgsVectorLayerUtils::valueExists( const QgsVectorLayer *layer, int fieldInd
   if ( !layer )
     return false;
 
-  const QgsFields fields = layer->fields();
+  QgsFields fields = layer->fields();
 
   if ( fieldIndex < 0 || fieldIndex >= fields.count() )
     return false;
 
-  const QgsField field = fields.at( fieldIndex );
+  QString fieldName = fields.at( fieldIndex ).name();
 
   // build up an optimised feature request
   QgsFeatureRequest request;
@@ -38,8 +38,8 @@ bool QgsVectorLayerUtils::valueExists( const QgsVectorLayer *layer, int fieldInd
   int limit = ignoreIds.size() + 1;
   request.setLimit( limit );
 
-  request.setFilterExpression( QStringLiteral( "%1=%2" ).arg( QgsExpression::quotedColumnRef( field.name() ),
-                               QgsExpression::quotedValue( value, field.type() ) ) );
+  request.setFilterExpression( QStringLiteral( "%1=%2" ).arg( QgsExpression::quotedColumnRef( fieldName ),
+                               QgsExpression::quotedValue( value ) ) );
 
   QgsFeature feat;
   QgsFeatureIterator it = layer->getFeatures( request );
