Remove progress task from identify action

nyalldawson · nyalldawson · commit 073c5be69f61 · 2018-11-23T20:32:31.000+11:00
Seems that some providers trigger an issue with the progress task (likely due to a local event loop running on the main thread triggering a processEvents call). Workaround the issue by just removing the progress task -- it's unlikely to be missed anyway. Fixes #20459 (cherry picked from commit 57c117c)
diff --git a/src/app/qgsmaptoolidentifyaction.cpp b/src/app/qgsmaptoolidentifyaction.cpp
@@ -38,7 +38,6 @@
 #include "qgsunittypes.h"
 #include "qgsstatusbar.h"
 #include "qgsactionscoperegistry.h"
-#include "qgsproxyprogresstask.h"
 #include "qgssettings.h"
 #include "qgsmapmouseevent.h"
 
@@ -112,14 +111,6 @@ void QgsMapToolIdentifyAction::showAttributeTable( QgsMapLayer *layer, const QLi
 void QgsMapToolIdentifyAction::identifyFromGeometry()
 {
   resultsDialog()->clear();
-
-  QgsProxyProgressTask *task = new QgsProxyProgressTask( tr( "Identifying features" ) );
-  QgsApplication::taskManager()->addTask( task );
-
-  connect( this, &QgsMapToolIdentifyAction::identifyProgress, task, [ = ]( int i, int n )
-  {
-    task->setProxyProgress( static_cast<double>( i ) * 100.0 / n );
-  } );
   connect( this, &QgsMapToolIdentifyAction::identifyMessage, QgisApp::instance(), &QgisApp::showStatusMessage );
 
   QgsGeometry geometry = mSelectionHandler->selectedGeometry();
@@ -139,7 +130,6 @@ void QgsMapToolIdentifyAction::identifyFromGeometry()
 
   QList<IdentifyResult> results = QgsMapToolIdentify::identify( geometry, mode, AllLayers );
 
-  task->finalize( true );
   disconnect( this, &QgsMapToolIdentifyAction::identifyMessage, QgisApp::instance(), &QgisApp::showStatusMessage );
 
   if ( results.isEmpty() )
