Remove unnecessary setAngle/angle overrides in QgsPointPatternFillSym…

…bolLayer
qgis · Apr 13, 2023 · 06ed5bd · 06ed5bd
1 parent db6627d
commit 06ed5bd
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 35 deletions.
diff --git a/python/core/auto_generated/symbology/qgsfillsymbollayer.sip.in b/python/core/auto_generated/symbology/qgsfillsymbollayer.sip.in
@@ -2457,31 +2457,12 @@ in different locations with every map refresh).
 
 .. seealso:: :py:func:`seed`
 
-.. versionadded:: 3.24
-%End
-
-    double angle() const;
-%Docstring
-Returns the rotation angle of the pattern, in degrees clockwise.
-
-.. seealso:: :py:func:`setAngle`
-
-.. versionadded:: 3.24
-%End
-
-    void setAngle( double angle );
-%Docstring
-Sets the rotation ``angle`` of the pattern, in degrees clockwise.
-
-.. seealso:: :py:func:`angle`
-
 .. versionadded:: 3.24
 %End
 
   protected:
 
 
-
     virtual void applyDataDefinedSettings( QgsSymbolRenderContext &context );
 
 

diff --git a/python/core/auto_generated/symbology/qgssymbollayer.sip.in b/python/core/auto_generated/symbology/qgssymbollayer.sip.in
@@ -1354,7 +1354,26 @@ The ``rings`` argument optionally specifies a list of polygon rings to render as
 
 
     void setAngle( double angle );
+%Docstring
+Sets the rotation ``angle`` of the pattern, in degrees clockwise.
+
+.. note::
+
+   Not all fill symbol layers support rotation.
+
+.. seealso:: :py:func:`angle`
+%End
+
     double angle() const;
+%Docstring
+Returns the rotation angle of the fill symbol, in degrees clockwise.
+
+.. note::
+
+   Not all fill symbol layers support rotation.
+
+.. seealso:: :py:func:`setAngle`
+%End
 
     virtual QImage toTiledPatternImage( ) const;
 %Docstring

diff --git a/src/core/symbology/qgsfillsymbollayer.h b/src/core/symbology/qgsfillsymbollayer.h
@@ -2177,22 +2177,6 @@ class CORE_EXPORT QgsPointPatternFillSymbolLayer: public QgsImageFillSymbolLayer
      */
     void setSeed( unsigned long seed ) { mSeed = seed; }
 
-    /**
-     * Returns the rotation angle of the pattern, in degrees clockwise.
-     *
-     * \see setAngle()
-     * \since QGIS 3.24
-     */
-    double angle() const { return mAngle; }
-
-    /**
-     * Sets the rotation \a angle of the pattern, in degrees clockwise.
-     *
-     * \see angle()
-     * \since QGIS 3.24
-     */
-    void setAngle( double angle ) { mAngle = angle; }
-
   protected:
     std::unique_ptr< QgsMarkerSymbol > mMarkerSymbol;
     double mDistanceX = 15;

diff --git a/src/core/symbology/qgssymbollayer.h b/src/core/symbology/qgssymbollayer.h
@@ -1272,7 +1272,22 @@ class CORE_EXPORT QgsFillSymbolLayer : public QgsSymbolLayer
 
     void drawPreviewIcon( QgsSymbolRenderContext &context, QSize size ) override;
 
+    /**
+     * Sets the rotation \a angle of the pattern, in degrees clockwise.
+     *
+     * \note Not all fill symbol layers support rotation.
+     *
+     * \see angle()
+     */
     void setAngle( double angle ) { mAngle = angle; }
+
+    /**
+     * Returns the rotation angle of the fill symbol, in degrees clockwise.
+     *
+     * \note Not all fill symbol layers support rotation.
+     *
+     * \see setAngle()
+     */
     double angle() const { return mAngle; }
 
     /**