PG: Silence warning when discovering relations on query layers

elpaso · nyalldawson · commit 06de70e702b2 · 2020-10-09T09:18:36.000+10:00
diff --git a/src/providers/postgres/qgspostgresprovider.cpp b/src/providers/postgres/qgspostgresprovider.cpp
@@ -4901,12 +4901,21 @@ QList<QgsVectorLayer *> QgsPostgresProvider::searchLayers( const QList<QgsVector
 QList<QgsRelation> QgsPostgresProvider::discoverRelations( const QgsVectorLayer *self, const QList<QgsVectorLayer *> &layers ) const
 {
   QList<QgsRelation> result;
+
+  // Silently skip if this is a query layer or for some obscure reason there are no table and schema name
+  if ( mIsQuery || mTableName.isEmpty() || mSchemaName.isEmpty() )
+  {
+    return result;
+  }
+
+  // Skip less silently if layer is not valid
   if ( !mValid )
   {
-    QgsLogger::warning( "Error getting the foreign keys of " + mTableName + ": invalid connection" );
+    QgsLogger::warning( QStringLiteral( "Error discovering relations of %1: invalid layer" ).arg( mQuery ) );
     return result;
   }
 
+
   QString sql(
     "WITH foreign_keys AS "
     "  ( SELECT c.conname, "
