Prevent builds which utilise API deprecated in <= Qt 5.8

Ideally this would be at least 5.9 (the minimum Qt version supported), but unfortunately the Qwt libraries utilise QString::null in public headers which was deprecated in Qt 5.9. I've got a feeling Qwt is going to be a pain point once again when Qt6 rolls around...
qgis · Feb 8, 2020 · 06d4dee · 06d4dee
1 parent aad4e84
commit 06d4dee
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -604,6 +604,10 @@ IF(MSVC)
   ADD_DEFINITIONS(-DNOMINMAX)
 ENDIF(MSVC)
 
+# Prevent build when Qt api deprecated before this Qt version is used:
+# Unfortunately Qwt uses deprecated QString::null in headers, preventing this being raised above 5.8
+ADD_DEFINITIONS(-DQT_DISABLE_DEPRECATED_BEFORE=0x050800)
+
 IF(ENABLE_COVERAGE)
   INCLUDE("cmake/modules/coverage/CodeCoverage.cmake")
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0 -fprofile-arcs -ftest-coverage --coverage")