[BUGFIX] [Spatialite] Finalize statement in addFeatures()

rouault · nyalldawson · commit 0626467a71a6 · 2016-03-12T20:27:42.000+11:00
The sqlite3_prepare_v2() call in QgsSpatiaLiteProvider::addFeatures() is not associated with a matching sqlite3_finalize(). Consequently at time of sqlite3_close(), the later returns a SQLITE_BUSY error and fails to close the file descriptor (can be checked by runing 'lsof' on qgis process). (cherry-picked from b0f2b97)
diff --git a/src/providers/spatialite/qgsspatialiteprovider.cpp b/src/providers/spatialite/qgsspatialiteprovider.cpp
@@ -3732,6 +3732,9 @@ bool QgsSpatiaLiteProvider::addFeatures( QgsFeatureList & flist )
           break;
         }
       }
+
+      sqlite3_finalize( stmt );
+
       if ( ret == SQLITE_DONE || ret == SQLITE_ROW )
       {
         ret = sqlite3_exec( sqliteHandle, "COMMIT", nullptr, nullptr, &errMsg );

Original file line number	Diff line number	Diff line change
`@@ -3732,6 +3732,9 @@ bool QgsSpatiaLiteProvider::addFeatures( QgsFeatureList & flist )`
`3732`	`3732`	`break;`
`3733`	`3733`	`}`
`3734`	`3734`	`}`
	`3735`	`+`
	`3736`	`+ sqlite3_finalize( stmt );`
	`3737`	`+`
`3735`	`3738`	`if ( ret == SQLITE_DONE \|\| ret == SQLITE_ROW )`
`3736`	`3739`	`{`
`3737`	`3740`	`ret = sqlite3_exec( sqliteHandle, "COMMIT", nullptr, nullptr, &errMsg );`