Init bool value in header and do not init qstring attributes with empty value

pblottiere · pblottiere · commit 05eeb87cda9d · 2017-10-09T05:01:35.000+01:00
diff --git a/src/core/qgsauxiliarystorage.cpp b/src/core/qgsauxiliarystorage.cpp
@@ -261,10 +261,7 @@ bool QgsAuxiliaryLayer::save()
 //
 
 QgsAuxiliaryStorage::QgsAuxiliaryStorage( const QgsProject &project, bool copy )
-  : mValid( false )
-  , mFileName( QString() )
-  , mTmpFileName( QString() )
-  , mCopy( copy )
+  : mCopy( copy )
 {
   initTmpFileName();
 
@@ -278,9 +275,7 @@ QgsAuxiliaryStorage::QgsAuxiliaryStorage( const QgsProject &project, bool copy )
 }
 
 QgsAuxiliaryStorage::QgsAuxiliaryStorage( const QString &filename, bool copy )
-  : mValid( false )
-  , mFileName( filename )
-  , mTmpFileName( QString() )
+  : mFileName( filename )
   , mCopy( copy )
 {
   initTmpFileName();
diff --git a/src/core/qgsauxiliarystorage.h b/src/core/qgsauxiliarystorage.h
@@ -305,10 +305,10 @@ class CORE_EXPORT QgsAuxiliaryStorage
     static bool exec( const QString &sql, sqlite3 *handler );
     static void debugMsg( const QString &sql, sqlite3 *handler );
 
-    bool mValid;
+    bool mValid = false;
     QString mFileName; // original filename
     QString mTmpFileName; // temporary filename used in copy mode
-    bool mCopy;
+    bool mCopy = false;
 };
 
 #endif

Original file line number	Diff line number	Diff line change
`@@ -261,10 +261,7 @@ bool QgsAuxiliaryLayer::save()`
`261`	`261`	`//`
`262`	`262`
`263`	`263`	`QgsAuxiliaryStorage::QgsAuxiliaryStorage( const QgsProject &project, bool copy )`
`264`		`- : mValid( false )`
`265`		`- , mFileName( QString() )`
`266`		`- , mTmpFileName( QString() )`
`267`		`- , mCopy( copy )`
	`264`	`+ : mCopy( copy )`
`268`	`265`	`{`
`269`	`266`	`initTmpFileName();`
`270`	`267`
`@@ -278,9 +275,7 @@ QgsAuxiliaryStorage::QgsAuxiliaryStorage( const QgsProject &project, bool copy )`
`278`	`275`	`}`
`279`	`276`
`280`	`277`	`QgsAuxiliaryStorage::QgsAuxiliaryStorage( const QString &filename, bool copy )`
`281`		`- : mValid( false )`
`282`		`- , mFileName( filename )`
`283`		`- , mTmpFileName( QString() )`
	`278`	`+ : mFileName( filename )`
`284`	`279`	`, mCopy( copy )`
`285`	`280`	`{`
`286`	`281`	`initTmpFileName();`