Use const ref when looping on layers

troopa81 · troopa81 · commit 053ab496b5ad · 2019-02-21T16:44:00.000+01:00
diff --git a/src/server/services/wms/qgswmsparameters.cpp b/src/server/services/wms/qgswmsparameters.cpp
@@ -1335,7 +1335,7 @@ namespace QgsWms
         if ( splits.size() == 2 )
         {
           const QStringList layers = splits[0].split( ',' );
-          for ( QString layer : layers )
+          for ( const QString& layer : layers )
           {
             QgsWmsParametersFilter filter;
             filter.mFilter = splits[1];

Original file line number	Diff line number	Diff line change
`@@ -1335,7 +1335,7 @@ namespace QgsWms`
`1335`	`1335`	`if ( splits.size() == 2 )`
`1336`	`1336`	`{`
`1337`	`1337`	`const QStringList layers = splits[0].split( ',' );`
`1338`		`- for ( QString layer : layers )`
	`1338`	`+ for ( const QString& layer : layers )`
`1339`	`1339`	`{`
`1340`	`1340`	`QgsWmsParametersFilter filter;`
`1341`	`1341`	`filter.mFilter = splits[1];`