Make QgsPointLocator discard geometries that cannot be projected

Sandro Santilli · Sandro Santilli · commit 0480cabfc913 · 2015-04-24T10:25:13.000+02:00
Fix #12634 (crash snapping in measure tool) To be backported to 2.8 branch
diff --git a/src/core/qgspointlocator.cpp b/src/core/qgspointlocator.cpp
@@ -633,7 +633,14 @@ bool QgsPointLocator::rebuildIndex( int maxFeaturesToIndex )
   {
     QgsRectangle rect = *mExtent;
     if ( mTransform )
-      rect = mTransform->transformBoundingBox( rect, QgsCoordinateTransform::ReverseTransform );
+    {
+      try {
+        rect = mTransform->transformBoundingBox( rect, QgsCoordinateTransform::ReverseTransform );
+      } catch (const QgsException& e) {
+        // See http://hub.qgis.org/issues/12634
+        QgsDebugMsg( QString("could not transform bounding box to map, skipping the snap filter (%1)").arg(e.what()) );
+      }
+    }
     request.setFilterRect( rect );
   }
   QgsFeatureIterator fi = mLayer->getFeatures( request );
@@ -644,7 +651,15 @@ bool QgsPointLocator::rebuildIndex( int maxFeaturesToIndex )
       continue;
 
     if ( mTransform )
-      f.geometry()->transform( *mTransform );
+    {
+      try {
+        f.geometry()->transform( *mTransform );
+      } catch (const QgsException& e) {
+        // See http://hub.qgis.org/issues/12634
+        QgsDebugMsg( QString("could not transform geometry to map, skipping the snap for it (%1)").arg(e.what()) );
+        continue;
+      }
+    }
 
     SpatialIndex::Region r( rect2region( f.geometry()->boundingBox() ) );
     dataList << new RTree::Data( 0, 0, r, f.id() );
@@ -708,7 +723,15 @@ void QgsPointLocator::onFeatureAdded( QgsFeatureId fid )
       return;
 
     if ( mTransform )
-      f.geometry()->transform( *mTransform );
+    {
+      try {
+        f.geometry()->transform( *mTransform );
+      } catch (const QgsException& e) {
+        // See http://hub.qgis.org/issues/12634
+        QgsDebugMsg( QString("could not transform geometry to map, skipping the snap for it (%1)").arg(e.what()) );
+        return;
+      }
+    }
 
     SpatialIndex::Region r( rect2region( f.geometry()->boundingBox() ) );
     mRTree->insertData( 0, 0, r, f.id() );
