[oracle] Fix expression compilation of integer division

nyalldawson · nyalldawson · commit 03e381524e98 · 2018-05-25T09:18:19.000+10:00
(cherry-picked from 60a71d1)
diff --git a/src/providers/oracle/qgsoracleexpressioncompiler.cpp b/src/providers/oracle/qgsoracleexpressioncompiler.cpp
@@ -38,6 +38,7 @@ QgsSqlExpressionCompiler::Result QgsOracleExpressionCompiler::compileNode( const
       case QgsExpression::boILike:
       case QgsExpression::boNotILike:
       case QgsExpression::boMod:
+      case QgsExpression::boIntDiv:
       {
         QString op1, op2;
 
@@ -63,13 +64,18 @@ QgsSqlExpressionCompiler::Result QgsOracleExpressionCompiler::compileNode( const
             result = QString( "NOT lower(%1) LIKE lower(%2)" ).arg( op1, op2 );
             return Complete;
 
+          case QgsExpression::boIntDiv:
+            result = QString( "FLOOR(%1 / %2)" ).arg( op1, op2 );
+            return Complete;
+
           case QgsExpression::boMod  :
             result = QString( "MOD(%1,%2)" ).arg( op1, op2 );
             return Complete;
 
           default:
             break;
         }
+        break; // no warnings
       }
 
       default:
@@ -94,7 +100,7 @@ QString QgsOracleExpressionCompiler::quotedValue( const QVariant& value, bool& o
   {
     case QVariant::Bool:
       //no boolean literal support in Oracle, so fake it
-      return value.toBool() ? "(1=1)" : "(1=0)";
+      return value.toBool() ? QString( "(1=1)" ) : QString( "(1=0)" );
 
     default:
       return QgsOracleConn::quotedValue( value );
