[Bugfix] Return false from QgsVectorLayer::setDataProvider if provider is not valid

manisandro · manisandro · commit 0360b457431c · 2019-03-19T16:22:18.000+01:00
diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -1594,6 +1594,7 @@ bool QgsVectorLayer::setDataProvider( QString const &provider, const QgsDataProv
   if ( !mValid )
   {
     QgsDebugMsgLevel( QStringLiteral( "Invalid provider plugin %1" ).arg( QString( mDataSource.toUtf8() ) ), 2 );
+    return false;
   }
 
   if ( mDataProvider->capabilities() & QgsVectorDataProvider::ReadLayerMetadata )

Original file line number	Diff line number	Diff line change
`@@ -1594,6 +1594,7 @@ bool QgsVectorLayer::setDataProvider( QString const &provider, const QgsDataProv`
`1594`	`1594`	`if ( !mValid )`
`1595`	`1595`	`{`
`1596`	`1596`	`QgsDebugMsgLevel( QStringLiteral( "Invalid provider plugin %1" ).arg( QString( mDataSource.toUtf8() ) ), 2 );`
	`1597`	`+ return false;`
`1597`	`1598`	`}`
`1598`	`1599`
`1599`	`1600`	`if ( mDataProvider->capabilities() & QgsVectorDataProvider::ReadLayerMetadata )`