Skip to content

Commit 0340320

Browse files
committedDec 20, 2016
[processing] fix wrong ParameterSelection definition
1 parent d129f8a commit 0340320

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

‎python/plugins/processing/algs/gdal/retile.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def defineCharacteristics(self):
8080
self.tr('Pixel size to be used for the output file (XSIZE YSIZE like 512 512)'),
8181
None, False, True))
8282
params.append(ParameterSelection(self.ALGORITHM,
83-
self.tr('Resampling algorithm'), self.ALGO, 0, False, True))
83+
self.tr('Resampling algorithm'), self.ALGO, 0, False, optional=True))
8484
params.append(ParameterCrs(self.S_SRS,
8585
self.tr('Override source CRS'), None, True))
8686
params.append(ParameterNumber(self.PYRAMIDLEVELS,
@@ -91,10 +91,10 @@ def defineCharacteristics(self):
9191
False, True))
9292
params.append(ParameterSelection(self.RTYPE,
9393
self.tr('Output raster type'),
94-
self.TYPE, 5, False, True))
94+
self.TYPE, 5, False, optional=True))
9595
params.append(ParameterSelection(self.FORMAT,
9696
self.tr('Output raster format'),
97-
list(GdalUtils.getSupportedRasters().keys()), 0, False, True))
97+
list(GdalUtils.getSupportedRasters().keys()), 0, False, optional=True))
9898
params.append(ParameterBoolean(self.USEDIRFOREACHROW,
9999
self.tr('Use a directory for each row'),
100100
False, True))

9 commit comments

Comments
 (9)

m-kuhn commented on Dec 20, 2016

@m-kuhn
Member

Wasn't the test for this commit failing before?

alexbruy commented on Dec 20, 2016

@alexbruy
ContributorAuthor

Yes, it failed before on Travis, but passed locally. Fixed after rerunning build

m-kuhn commented on Dec 20, 2016

@m-kuhn
Member

It failed in the followup commit (which I only made to debug this failure)

https://travis-ci.org/qgis/QGIS/builds/185500692#L840-L843

Any idea?

alexbruy commented on Dec 20, 2016

@alexbruy
ContributorAuthor

I have no ideas, this commit even not related to failed test. Trying to debug it right now

m-kuhn commented on Dec 21, 2016

@m-kuhn
Member

Did you find anything?
All builds are currently failing.

ghtmtt commented on Dec 21, 2016

@ghtmtt
Contributor

I don't know if could help, but locally the test runs without problems:

The following tests passed:
	ProcessingParametersTest

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   1.83 sec

m-kuhn commented on Dec 21, 2016

@m-kuhn
Member

It only fails 1 out of 5 times.

Probably since 97780b6

ghtmtt commented on Dec 21, 2016

@ghtmtt
Contributor

OK I see.. Can I help in some way?

m-kuhn commented on Dec 21, 2016

@m-kuhn
Member

Someone needs to fix ParameterFixedTable.fromScriptCode which was probably copied from ParameterPoint and not completely adjusted.

Please sign in to comment.