Always mark features as valid when added to memory provider

nyalldawson · nyalldawson · commit 0234cd2988d0 · 2016-05-25T16:04:08.000+10:00
For other providers features will automatically be made valid through the proces of adding to the provider's storage itself and then later retrieving via iterators. But the memory provider uses a direct copy of the feature, so if we don't explicitly mark features as valid the provider may be returning features incorrectly marked as invalid. (cherry-picked from f2b70cf)
diff --git a/src/providers/memory/qgsmemoryprovider.cpp b/src/providers/memory/qgsmemoryprovider.cpp
@@ -334,6 +334,7 @@ bool QgsMemoryProvider::addFeatures( QgsFeatureList & flist )
     mFeatures[mNextFeatureId] = *it;
     QgsFeature& newfeat = mFeatures[mNextFeatureId];
     newfeat.setFeatureId( mNextFeatureId );
+    newfeat.setValid( true );
     it->setFeatureId( mNextFeatureId );
 
     // update spatial index
