Merge pull request #37587 from mhugent/max_symbol_size_unit_test

Add unit test for maximum symbol size in legend
qgis · Jul 6, 2020 · 01b345c · 01b345c
2 parents 7c89280 + afdfec3
commit 01b345c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/tests/src/core/testqgslegendrenderer.cpp b/tests/src/core/testqgslegendrenderer.cpp
@@ -141,6 +141,7 @@ class TestQgsLegendRenderer : public QObject
     void testSpacing();
     void testEffects();
     void testBigMarker();
+    void testBigMarkerMaxSize();
     void testOverrideSymbol();
 
     void testRightAlignText();
@@ -496,6 +497,24 @@ void TestQgsLegendRenderer::testBigMarker()
   QVERIFY( _verifyImage( testName, mReport ) );
 }
 
+void TestQgsLegendRenderer::testBigMarkerMaxSize()
+{
+  QString testName = QStringLiteral( "legend_big_marker_max_size" );
+  QgsMarkerSymbol *sym = new QgsMarkerSymbol();
+  sym->setColor( Qt::red );
+  sym->setSize( sym->size() * 6 );
+  QgsCategorizedSymbolRenderer *catRenderer = dynamic_cast<QgsCategorizedSymbolRenderer *>( mVL3->renderer() );
+  QVERIFY( catRenderer );
+  catRenderer->updateCategorySymbol( 0, sym );
+
+  QgsLayerTreeModel legendModel( mRoot );
+  QgsLegendSettings settings;
+  settings.setMaxSymbolSize( 5 ); //restrict maximum size to 5 mm
+  _setStandardTestFont( settings, QStringLiteral( "Bold" ) );
+  _renderLegend( testName, &legendModel, settings );
+  QVERIFY( _verifyImage( testName, mReport ) );
+}
+
 void TestQgsLegendRenderer::testOverrideSymbol()
 {
   QString testName = QStringLiteral( "legend_override_symbol" );

diff --git a/...end/expected_legend_big_marker_max_size/expected_legend_big_marker_max_size.png b/...end/expected_legend_big_marker_max_size/expected_legend_big_marker_max_size.png