Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Tweak context for composer items
- Attribute tables have access to layer context when applicable
- Frames have access to parent multiframe's context
  • Loading branch information
nyalldawson committed Aug 22, 2015
1 parent be26c61 commit 00892ce
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/core/composer/qgscomposerattributetablev2.cpp
Expand Up @@ -583,6 +583,18 @@ bool QgsComposerAttributeTableV2::getTableContents( QgsComposerTableContents &co
return true;
}

QgsExpressionContext *QgsComposerAttributeTableV2::createExpressionContext() const
{
QgsExpressionContext* context = QgsComposerTableV2::createExpressionContext();

if ( mSource == LayerAttributes )
{
context->appendScope( QgsExpressionContextUtils::layerScope( mVectorLayer ) );
}

return context;
}

QVariant QgsComposerAttributeTableV2::replaceWrapChar( const QVariant &variant ) const
{
//avoid converting variants to string if not required (try to maintain original type for sorting)
Expand Down
2 changes: 2 additions & 0 deletions src/core/composer/qgscomposerattributetablev2.h
Expand Up @@ -293,6 +293,8 @@ class CORE_EXPORT QgsComposerAttributeTableV2: public QgsComposerTableV2
*/
bool getTableContents( QgsComposerTableContents &contents ) override;

virtual QgsExpressionContext* createExpressionContext() const override;

private:

/** Attribute source*/
Expand Down
13 changes: 13 additions & 0 deletions src/core/composer/qgscomposerframe.cpp
Expand Up @@ -115,6 +115,19 @@ bool QgsComposerFrame::isEmpty() const

}

QgsExpressionContext *QgsComposerFrame::createExpressionContext() const
{
if ( !mMultiFrame )
return QgsComposerItem::createExpressionContext();

//start with multiframe's context
QgsExpressionContext* context = mMultiFrame->createExpressionContext();
//add frame's individual context
context->appendScope( QgsExpressionContextUtils::composerItemScope( this ) );

return context;
}

QString QgsComposerFrame::displayName() const
{
if ( !id().isEmpty() )
Expand Down
2 changes: 2 additions & 0 deletions src/core/composer/qgscomposerframe.h
Expand Up @@ -100,6 +100,8 @@ class CORE_EXPORT QgsComposerFrame: public QgsComposerItem
*/
bool isEmpty() const;

virtual QgsExpressionContext* createExpressionContext() const override;

private:
QgsComposerFrame(); //forbidden
QgsComposerMultiFrame* mMultiFrame;
Expand Down

0 comments on commit 00892ce

Please sign in to comment.