https://issues.qgis.org/https://issues.qgis.org/favicon.ico2014-02-16T03:47:09ZQGIS Issue TrackingQGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=486892014-02-16T03:47:09ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Target version</strong> set to <i>Version 2.2</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><p>I'm on qgis master/ubuntu and it's weird because what I see is:</p>
<ul>
<li>for lines I see what you describe for polygons</li>
</ul>
<ul>
<li>for polygons I see something similar to what you describe for lines, but instead of having 3 nodes created on the segment, for me are just 2</li>
</ul> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=487712014-02-17T20:19:53ZLeyan Ouyang
<ul></ul><p>I made some more investigation: the number of nodes created is not linked to the type of layer, but to the number of layers added after the layer edited (and with snapping active). The issue is linked to the <a href="https://github.com/qgis/QGIS/blob/master/src/app/nodetool/qgsmaptoolnodetool.cpp#L554" class="external">call</a> to <a href="https://github.com/qgis/QGIS/blob/master/src/core/qgsvectorlayereditutils.cpp#L593" class="external">QgsVectorLayerEditUtils::insertSegmentVerticesForSnap</a> before moving the selected vertices.</p> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=488822014-02-19T10:44:08ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>fixed/implemented</i></li></ul><p>I cannot replicate anymore on the latest master, something has changed, for the better. Please reopen if I'm wrong.</p> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=489582014-02-21T05:21:12ZLeyan Ouyang
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Nothing changed from my side, I did not see any commit related to that either.</p>
<p>Could someone else confirm whether they can see the bug ?</p> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=489612014-02-21T05:32:26ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Leyan Ouyang wrote:</p>
<blockquote>
<p>Nothing changed from my side, I did not see any commit related to that either.</p>
<p>Could someone else confirm whether they can see the bug ?</p>
</blockquote>
<p>are you using the latest master? on what platform? what revision are you testing?</p> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=489712014-02-21T19:38:49ZLeyan Ouyang
<ul></ul><p>I tried with revision 882dd0c pulled yesterday. I am on Linux (Archlinux), but I don't think it can be platform-specific.</p>
<p>From my understanding, the bug is linked to mapnodetool calling insertSegmentVerticesForSnap (the call is <a href="https://github.com/qgis/QGIS/blob/master/src/app/nodetool/qgsmaptoolnodetool.cpp#L554" class="external">here</a> , to this <a href="https://github.com/qgis/QGIS/blob/master/src/core/qgsvectorlayereditutils.cpp#L593" class="external">function</a> ). The function insertSegmentVerticesForSnap will insert one vertex for each snapping result, but it seems this insertion will mess with the vertex indice when later moving the point which was manipulated.</p>
<p>To solve this, the vertex insertion could be done after the original vertex moving, so that it is not affected. Then the insertSegmentVerticesForSnap needs to be improved to avoid inserting several points at the same position.</p>
<p>Nothing was changed recently in these two functions, so I don't know how the bug could have disappeared. Now the result is correct for you?</p> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=489992014-02-23T00:07:59ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Resolution</strong> deleted (<del><i>fixed/implemented</i></del>)</li><li><strong>Target version</strong> changed from <i>Version 2.2</i> to <i>Version 2.4</i></li></ul><p>Leyan Ouyang wrote:</p>
<blockquote>
<p>Now the result is correct for you?</p>
</blockquote>
<p>no you are right, I forgot an import detail when I tested the second time.</p> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=492772014-03-01T07:27:17ZJürgen Fischerjef@norbit.de
<ul><li><strong>Target version</strong> changed from <i>Version 2.4</i> to <i>Future Release - High Priority</i></li></ul> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=784282017-04-30T23:08:50ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Regression?</strong> set to <i>No</i></li><li><strong>Easy fix?</strong> set to <i>No</i></li></ul> QGIS Application - Bug report #9569: Unexpected result in topological editing when snapping to the line element currently being editedhttps://issues.qgis.org/issues/9569?journal_id=1024042019-03-09T15:04:50ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Resolution</strong> set to <i>end of life</i></li><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p><strong>End of life notice: QGIS 2.18 LTR</strong>
<strong><br />Source:</strong><br /><a class="external" href="http://blog.qgis.org/2019/03/09/end-of-life-notice-qgis-2-18-ltr/">http://blog.qgis.org/2019/03/09/end-of-life-notice-qgis-2-18-ltr/</a></p>