https://issues.qgis.org/https://issues.qgis.org/favicon.ico2008-02-01T02:29:33ZQGIS Issue TrackingQGIS Application - Bug report #932: Zoom Full, Zoom To Layer and Zoom To Selection work wronghttps://issues.qgis.org/issues/932?journal_id=162352008-02-01T02:29:33ZMagnus Homann
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>In Progress</i></li></ul><p>With Qt drawing system, it can never be moer exact than it is. The line border width makes a difference regarding 1 or 2 pixels.</p>
<p>Zoom to layer was changed to give a margin around the layer, possibly the same should be done for the other zoom tools also.</p>
<p>See <a class="issue tracker-1 status-5 priority-3 priority- closed" href="https://issues.qgis.org/issues/881" title="Excesive zoom-in after 'Zoom to layer extent' (Closed)">#881</a></p> QGIS Application - Bug report #932: Zoom Full, Zoom To Layer and Zoom To Selection work wronghttps://issues.qgis.org/issues/932?journal_id=162362008-02-02T09:58:01ZMagnus Homann
<ul><li><strong>Resolution</strong> set to <i>fixed</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Closed</i></li></ul><p>I added the same margin (5%) for all three zoom methods in <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/bc200fe8f98a89191b66a00f77b7f303e4e53fd8" title="Make zoomToLayer, zoomFull and zoomSelected all adds the same five percent margin around the exte...">bc200fe8</a> (SVN r8100).</p> QGIS Application - Bug report #932: Zoom Full, Zoom To Layer and Zoom To Selection work wronghttps://issues.qgis.org/issues/932?journal_id=162372008-02-06T11:09:57ZMaciej Sieczka -tutey@o2.pl
<ul><li><strong>Resolution</strong> deleted (<del><i>fixed</i></del>)</li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Feedback</i></li></ul><p>Replying to [comment:1 homann]:</p>
<blockquote>
<p>With Qt drawing system, it can never be moer exact than it is.</p>
</blockquote>
<p>Hmm, but it works perfectly fine, to a single pixel, in QGIS 0.8.1 <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/93e45f0d49dfc795801d99b3811d4b225bcd2cca" title="Added some more helpful stdout stuff git-svn-id: http://svn.osgeo.org/qgis/trunk@7193 c8812cc2-...">93e45f0d</a> (SVN r7194), while in 0.9 SVN <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/9b7ec28674a3cf1ae8b7decfb1bc980da117100a" title="Eliminate GEOS 3.0 deprecated header warnings by including individual headers instead of deprecat...">9b7ec286</a> (SVN r8099) it doesn't, with the same data. Both QGIS versions built against QT 4.3.3. Seems like a regression. Smallish but anyway. Maybe worth looking into, might a symptom of some undesired change?</p>
<blockquote>
<p>The line border width makes a difference regarding 1 or 2 pixels.</p>
</blockquote>
<p>Not the case. I'm reffering to a default 1 pixel width in all examples here.</p>
<p>As to the forced 5% margin when zooming too a layer/selection/all - generally good idea, but not always desired. Best if it was configurable.</p> QGIS Application - Bug report #932: Zoom Full, Zoom To Layer and Zoom To Selection work wronghttps://issues.qgis.org/issues/932?journal_id=162382008-02-06T11:38:33ZMagnus Homann
<ul></ul><p>Can you please re-state what you think does not work as expected? A 5% margin means that there is normally more than 1 pixel between layer and canvas edge, so that is not a problem anymore.</p>
<p>0.9.2 is closed for bug fixing.</p> QGIS Application - Bug report #932: Zoom Full, Zoom To Layer and Zoom To Selection work wronghttps://issues.qgis.org/issues/932?journal_id=162392008-02-07T10:29:50Zsieczka -sieczka@foo.bar
<ul></ul><p>Replying to [comment:4 homann]:</p>
<blockquote>
<p>Can you please re-state what you think does not work as expected?</p>
</blockquote>
<p>If not the 5% margin, there is a 1 pixel offset to the right and bottom when you zoom to layer/selection/all.</p>
<blockquote>
<p>A 5% margin means that there is normally more than 1 pixel between layer and canvas edge,<br />so that is not a problem anymore.</p>
</blockquote>
<p>The recently introduced 5% margin just hides the issue, not fix it.</p>
<p>Since in QGIS 0.8.1 the 1 pixel offset at zoom to layer/selection/all is not present, and it is present in 0.9, it's a regression.</p>
<blockquote>
<p>0.9.2 is closed for bug fixing.</p>
</blockquote>
<p>Too bad.</p> QGIS Application - Bug report #932: Zoom Full, Zoom To Layer and Zoom To Selection work wronghttps://issues.qgis.org/issues/932?journal_id=162402008-02-09T07:11:22ZMagnus Homann
<ul><li><strong>Resolution</strong> set to <i>fixed</i></li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li></ul><p>1) We got an enhancement request for a margin when zooming. I agreed, posted a question to the amiling list and got no objections and changed the functionality.<br />2) As the functionality has changed intentionality , it will not work the same as in 0.8.1 and it should not either. There is no regression problem.<br />3) Even in 0.8.1 it did not work reliably as you state, as it was dependent on line width (I have verified this).</p>
<p>For these three reasons, I will mark this issue as closed. If you want the old functionality back, open a new issue and mark it as enhancement (or re-name this).</p> QGIS Application - Bug report #932: Zoom Full, Zoom To Layer and Zoom To Selection work wronghttps://issues.qgis.org/issues/932?journal_id=162412009-08-21T22:57:01ZAnonymous
<ul></ul><p>Milestone Version 1.0.0 deleted</p>