https://issues.qgis.org/https://issues.qgis.org/favicon.ico2013-06-15T03:14:27ZQGIS Issue TrackingQGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=420472013-06-15T03:14:27ZFilipe Dias
<ul><li><strong>Operating System</strong> set to <i>Linux</i></li><li><strong>OS version</strong> set to <i>Ubuntu 12.04</i></li></ul> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=420482013-06-15T03:40:57ZFilipe Dias
<ul></ul><p>Im using the latest version before the SIP update.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=420492013-06-15T04:23:58ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><p>Filipe Dias wrote:</p>
<blockquote>
<p>Im using the latest version before the SIP update.</p>
</blockquote>
<p>then you should re-test after updating, the code of the core python plugins have already been changed, so testing not the latest revision does not make sense anyway.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=420502013-06-15T04:30:55ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>OS version</strong> deleted (<del><i>Ubuntu 12.04</i></del>)</li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li><li><strong>Target version</strong> set to <i>Version 2.0.0</i></li><li><strong>Operating System</strong> deleted (<del><i>Linux</i></del>)</li></ul><p>If you choose a column with no values (and it should have something to work) then the error is the one you report.</p>
<p>Anyway on the latest revision it fails with</p>
<pre>
An error has occured while executing Python code:
Traceback (most recent call last):
File "/usr/share/qgis/python/plugins/fTools/tools/doRandPoints.py", line 94, in accept
if outPath.contains("\\\\"):
AttributeError: 'unicode' object has no attribute 'contains'
Python version:
2.7.3 (default, Aug 1 2012, 05:25:23)
[GCC 4.6.3]
</pre>
<p>even when choosing a column that makes sense.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=420512013-06-15T04:37:58ZFilipe Dias
<ul></ul><p>Of course it should not be empty. But a warning message should be displayed (e.g. The selected field has NULL values) instead of a Python error.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=420572013-06-15T11:50:17ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Hi Filipe,</p>
<p>Filipe Dias wrote:</p>
<blockquote>
<p>Of course it should not be empty. But a warning message should be displayed (e.g. The selected field has NULL values) instead of a Python error.</p>
</blockquote>
<p>yes of course, that situation would need to be trapped, but that is not would not be enough to make this a blocker. On the other hand the tools nows fail anyway so after all this is really a regression.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=420732013-06-16T01:41:08ZMatthias Kuhn
<ul><li><strong>Priority</strong> changed from <i>Severe/Regression</i> to <i>Normal</i></li></ul><p>The error (unicode object has no attribute contains) should be resolved. I will leave it open for the missing check for suitable values and an appropriate warning.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=427962013-07-09T15:01:20ZDaniel Vazdanielvaz@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Fixed in <a class="external" href="https://github.com/ddanielvaz/Quantum-GIS/commit/801cde9d9418b8c25a070b8f5bee02cef324e57e">https://github.com/ddanielvaz/Quantum-GIS/commit/801cde9d9418b8c25a070b8f5bee02cef324e57e</a></p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=428032013-07-09T23:05:43ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>In Progress</i></li><li><strong>Pull Request or Patch supplied</strong> changed from <i>No</i> to <i>Yes</i></li></ul> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=428052013-07-09T23:11:22ZFilipe Dias
<ul></ul><p>Yes it's better to close the ticket only when the pull request is merged. Thanks for fixing this Daniel.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=428162013-07-10T02:54:02ZDaniel Vazdanielvaz@gmail.com
<ul></ul><p>Sorry about closing the bug...</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=428382013-07-10T16:11:15ZNathan Woodrow
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Closed</i></li></ul><p>Fixed in changeset <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/56210eb0b5c7914d246b1c82ad48e676b00b6557" title="Merge pull request #711 from ddanielvaz/bugfixes Bugfixes for fTools. Fix #8218 Fix #8069 Fix #...">56210eb0b5c7914d246b1c82ad48e676b00b6557</a>.</p> QGIS Application - Bug report #8069: Ftools random points: a python error https://issues.qgis.org/issues/8069?journal_id=788442017-04-30T23:21:49ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>The "ftools" category is being removed from the tracker, changing the category of this ticket to "Processing/QGIS" to not leave the category orphaned.</p>