https://issues.qgis.org/https://issues.qgis.org/favicon.ico2007-02-25T18:33:24ZQGIS Issue TrackingQGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148652007-02-25T18:33:24ZTim Suttontim@linfiniti.com
<ul></ul><p>Moved to milestone 0.8.2 since we wont be fixing any further issues before the 0.8.1 release</p> QGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148662007-11-27T14:00:44ZAaron Racicot -aaronr@z-pulley.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>In Progress</i></li></ul> QGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148672007-11-28T17:31:41ZAaron Racicot -aaronr@z-pulley.com
<ul></ul><p>Patch attached to fix this bug. Added bool value to signal for legend refresh to specify whether the legend item is expanded. Submitted by CUGOS group 11/28/07.</p> QGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148682007-11-28T18:31:07ZTim Suttontim@linfiniti.com
<ul></ul><p>Hi</p>
<p>I wonder what effect this change in qgsapplicatoninterface will have on third party apps:</p>
<p>148 qgis->legend()->refreshLayerSymbology( l->getLayerID() ); <br />148 qgis->legend()->refreshLayerSymbology( l->getLayerID(), true );</p>
<p>While we dont promise binary comatibility between releases it will be nice to maintain it where poss. I wonder if useing a default of bool expand=true would not be better so that we can leave the qgsapplication api unchanged if possible.</p>
<p>Regards</p>
<p>Tim</p> QGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148692007-11-28T23:22:50ZAaron Racicot -aaronr@z-pulley.com
<ul></ul><p>Hi Tim,</p>
<p>Well, the API in qgsapplication did not actually change... only the api for <a class="wiki-page new" href="https://issues.qgis.org/projects/qgis/wiki/QgsLegend">QgsLegend</a>::refreshLayerSymbology and the signal refreshLegend had actually changed. In the qgsapplication the "default" value was just being passed in as a hard coded "true". I agree that this should actually just be a default value on the second param to <a class="wiki-page new" href="https://issues.qgis.org/projects/qgis/wiki/QgsLegend">QgsLegend</a>::refreshLayerSymbology. I went ahead and made the change so now the prototype for that is:</p>
<p>void refreshLayerSymbology(QString key, bool expandItem = true);</p>
<p>This allows all of the original calls to refreshLayerSymbology to remain unchanged and just the new param that is added to the refreshLegend signal is passed on to refreshLayerSymbology to override the default true value.</p>
<p>Hope this better follows the conventions... a new patch is attached.</p>
<p>Aaron</p> QGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148702007-11-29T01:17:24ZTim Suttontim@linfiniti.com
<ul></ul><p>Hi</p>
<p>You patch was applied as <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/97bb326f48c96ee7b59fd17ca654d4aa6f8b8429" title="Applied patch from Aaron for ticket #572 git-svn-id: http://svn.osgeo.org/qgis/trunk@7683 c881...">97bb326f</a> (SVN r7684) - many thanks!</p>
<p>Regards</p>
<p>Tim</p> QGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148712007-11-29T09:20:01ZAaron Racicot -aaronr@z-pulley.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>fixed</i></li></ul><p>Marking as fixed after Tim applied the patch. Thanks Tim</p> QGIS Application - Bug report #572: change any property of a vector layer (transparency, labels etc.) = the layer gets expandedhttps://issues.qgis.org/issues/572?journal_id=148722009-08-21T22:52:53ZAnonymous
<ul></ul><p>Milestone Version 0.9.1 deleted</p>