https://issues.qgis.org/https://issues.qgis.org/favicon.ico2011-03-03T23:09:20ZQGIS Issue TrackingQGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239782011-03-03T23:09:20ZMathieu Pellerin - nIRVnirvn.asia@gmail.com
<ul></ul><p>Since the new symbology engine will be the default in 1.7, I think devs should look at this lost of feature from old to new symbology. I've attached screenshots (old engine, new engine, and one map example) in case my description above was unclear.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239792011-03-30T21:25:32Zsunilkcube -sunilkcube@foo.bar
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>In Progress</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239802011-04-01T02:26:07Zsunilkcube -sunilkcube@foo.bar
<ul></ul><p>The patch has been added above. Can anyone please kindly review the patch and if you have any comments let me know , I will soon work on your comments and try to resolve that ?. Thanks .</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239812011-05-01T00:17:55ZAlister Hood
<ul></ul><p>Thanks Sunil; I'm not someone who can review the patch, but it seems to work well :)</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239822011-05-01T01:22:19ZAlister Hood
<ul></ul><p>I find that I can switch a layer from old symbology to new symbology successfully, but not back again. The patch could be improved slightly by allowing it to switch back, but I think this is a very minor issue (probably not worth the effort to fix) if old symbology is to be removed from QGIS soon.</p>
<p>e.g.</p>
<p>- select the first point symbol (circle) in old symbology, set the fill options to "None", Apply</p>
<p>- switch to new symbology and Apply - the markers should stay the same (apart from outline width, which is <a class="issue tracker-1 status-5 priority-4 priority- closed" href="https://issues.qgis.org/issues/3458" title="New Symbology: Simple Markers don't allow to specify stroke-width (Closed)">#3458</a>)</p>
<p>- switch to old symbology - the markers will now have a solid fill</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239832011-05-01T03:11:26ZAlister Hood
<ul></ul><p>Also, I'm pretty sure this part of your patch breaks the dialogue somewhat: <br /><pre>
- connect( spinAngle, SIGNAL( valueChanged( double ) ), this, SLOT( setAngle() ) );
</pre></p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239842011-05-01T03:16:16ZAlister Hood
<ul></ul><p>I'm guessing you actually meant to delete the line above that, as it is the same as the line the patch adds below, so the same line will appear twice if the patch is used.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239852011-05-02T20:59:28Zsunilkcube -sunilkcube@foo.bar
<ul></ul><p>Replying to [comment:9 Alister]:</p>
<blockquote>
<p>I'm guessing you actually meant to delete the line above that, as it is the same as the line the patch adds below, so the same line will appear twice if the patch is used.</p>
</blockquote>
<p>Thanks for reviewing the patch. Yes you are right I have done mistake while patching. I have attached a new patch can you please kindly review this one also ?</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239862011-05-03T00:06:15ZAlister Hood
<ul></ul><p>Hmmm. I didn't realise transparency wasn't working. I'm guessing uncommenting this in the new patch was supposed to fix it:<br /><pre>
// selColor.setAlphaF( context.alpha() );
</pre><br />But transparency for the symbol fill still doesn't work for me... unless QGIS hasn't rebuilt properly.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239872011-05-03T00:19:19ZAlister Hood
<ul></ul><p>Like I say, I can't "review" the patch as I have almost no knowledge of C++, QT or the internals of QGIS.</p>
<p>I've noticed another thing that could be improved though: when you select a feature, the fill style is not applied to it.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239882011-05-03T00:26:59ZAlister Hood
<ul></ul><p>see attached screenshot:</p>
<p>- fill style is not applied to selected features (actually, it looks like selected points are rendered by simply filling each symbol layer with yellow, so if transparency is applied the yellow is darker where two symbol layers overlap). I don't think this is a significant problem.</p>
<p>- transparency is only applied to borders, not fills.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239892011-05-03T00:29:33ZAlister Hood
<ul></ul><blockquote>
<p>- transparency is only applied to borders, not fills.</p>
</blockquote>
<p>But it is applied to the yellow fill for selected features, as you can see :)</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239902011-05-05T01:42:34ZAlister Hood
<ul></ul><p>.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239912011-05-05T01:47:54ZAlister Hood
<ul></ul><p>.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239922011-05-05T01:54:20ZAlister Hood
<ul></ul><p>Ah - there's a preview button! I should use it ;)<br />-----------</p>
<blockquote>
<p>- fill style is not applied to selected features (actually, it looks like selected points are rendered by simply filling each symbol layer with yellow, so if transparency is applied the yellow is darker where two symbol layers overlap). I don't think this is a significant problem.</p>
</blockquote>
<blockquote>
<p>- transparency is only applied to borders, not fills.</p>
</blockquote>
<p>OK, that was easier than I expected. I've had a look at it, and fixed those things, and also what I'm pretty sure was a pre-existing mistake in this line:</p>
<pre>
QColor selPenColor = selBrushColor == mColor ? selBrushColor : mBorderColor;
</pre>
<p>I had to tidy/rearrange that section of code so I could understand it :)</p>
<p>I added a number of comments, mostly about inconsistencies compared with how QGIS renders polygon layers. Can someone else look at these and tell me what they think?</p>
<p>There is one reasonably annoying bug:</p>
<pre>
//"no fill" doesn't work if brushColor = penColor
// e.g. if the symbol is a circle, the whole bounding box (is that what it's called?)
// of the circle is filled.
</pre>
<p>I'm guessing to fix this an if statement is required something like the one I commented out because that method didn't work. But I don't know what to put in it!</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239932011-05-05T01:59:09ZAlister Hood
<ul></ul><p>Oh, yeah - I noticed another problem.</p>
<p>In the symbol layers box with these patches it only shows the fill, whereas it used to show a preview of the symbol layer.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239942011-05-08T03:59:24ZAlister Hood
<ul></ul><blockquote>
<p>//"no fill" doesn't work if brushColor = penColor</p>
</blockquote>
<blockquote>
<p>// e.g. if the symbol is a circle, the whole bounding box (is that what it's called?)</p>
</blockquote>
<blockquote>
<p>// of the circle is filled.</p>
</blockquote>
<p>Actually, this isn't quite right. It definitely happens sometimes with no fill, but I can't figure out exactly when... it looks like it is something to do with the order in which I change the settings or something odd like that.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239952011-05-08T18:20:02ZAlister Hood
<ul></ul><p>Oh, of course.</p>
<p>We shouldn't apply the fill style to selected features unless either we have a special pen colour for selected features (personally I think this would be nice), or we check to make sure the fill style isn't "no fill".</p>
<p>If the fill style is "no fill" and we apply it to selected features, then they look the same as unselected features :)</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239962011-05-08T18:46:05ZAlister Hood
<ul></ul><p>Oh, and I think I was wrong about this:</p>
<pre>
// Alister - I don't understand the reasoning for the following line
// QColor selPenColor = selBrushColor == mColor ? selBrushColor : mBorderColor;
// I think it is a mistake and is meant to be this
QColor selPenColor = mBorderColor == mColor ? selBrushColor : mBorderColor ;
</pre>
<p>This wouldn't have been a mistake - it is trying to make the selection look different if the symbol fill is the same colour as the selection fill. But there are still things that could be improved here: it won't achieve anything if the symbol fill and the symbol outline are <em>both</em> the same colour as the selection fill. Also, polygon layers aren't dealt with in the same way, and they probably should be.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239972011-05-08T20:51:44ZAlister Hood
<ul></ul><blockquote>
<p>Oh, yeah - I noticed another problem.</p>
<p>In the symbol layers box with these patches it only shows the fill, whereas it used to show a preview of the symbol layer.</p>
</blockquote>
<p>Sorry, my mistake again - the preview works fine. I must have been testing with symbols larger than the space that the preview fits in.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239982011-05-09T00:35:39ZAlister Hood
<ul></ul><p>Please disregard my patch for now. After looking at it again I came to understand how some things were intended to work.</p>
<p>I have made some changes to make the display of selected features in point symbology more consistent with polygon and polyline features, but I'll check them in the next day or so before posting a new patch.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=239992011-05-24T21:31:18ZAlister Hood
<ul></ul><p>Ah, sorry. That's a long couple of days :(</p>
<p>Please see the new patch. I was hoping to do more to improve the consistency between points, polylines and polygons, but I won't have a chance to do any more for a while.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=271402011-12-16T12:49:15ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Target version</strong> changed from <i>Version 1.7.0</i> to <i>Version 1.7.4</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=304242012-04-15T08:10:55ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Target version</strong> changed from <i>Version 1.7.4</i> to <i>Version 2.0.0</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=313412012-04-17T22:50:28ZJürgen Fischerjef@norbit.de
<ul><li><strong>Assignee</strong> deleted (<del><i>sunilkcube -</i></del>)</li><li><strong>Pull Request or Patch supplied</strong> set to <i>No</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=340182012-08-20T22:58:24ZAlister Hood
<ul><li><strong>File</strong> <a href="/attachments/download/4801/patch_for_bug__3430_alister_21-8-12.diff">patch_for_bug__3430_alister_21-8-12.diff</a><a href="/attachments/4801/patch_for_bug__3430_alister_21-8-12.diff"><img alt="Magnifier" src="/images/magnifier.png" /></a> added</li><li><strong>Priority</strong> changed from <i>Low</i> to <i>Normal</i></li><li><strong>Status info</strong> deleted (<del><i>0</i></del>)</li></ul><p>Here's an updated patch against current master.</p>
<p>If SLD supports marker symbol fill styles then the SLD import/export will need more work. At the moment it should just apply the default fill style (solid fill).</p>
<p>------<br />I guess this ticket should not be "low" priority. If this functionality is needed for QGIS 2.0 then maybe tickets like this should be "blockers"!</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=340222012-08-21T01:04:47ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Hi Alister</p>
<p>Alister Hood wrote:</p>
<blockquote>
<p>Here's an updated patch against current master.</p>
</blockquote>
<p>it would be better to submit the patch as pull request on github, the are more chances to have it reviewed and committed.</p>
<blockquote>
<p>------<br />I guess this ticket should not be "low" priority. If this functionality is needed for QGIS 2.0 then maybe tickets like this should be "blockers"!</p>
</blockquote>
<p>"Blockers" are regressions, so I guess that this could fit. Anyway the list of missing features in new symbology (available in the old one) is quite long, so instead we have wiki page</p>
<p><a class="external" href="https://issues.qgis.org/projects/quantum-gis/wiki/Switching_from_Old_to_New_Symbology_and_Labeling/">https://issues.qgis.org/projects/quantum-gis/wiki/Switching_from_Old_to_New_Symbology_and_Labeling/</a></p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=341332012-08-27T02:37:11ZGiuseppe Sucamelibrush.tyler@gmail.com
<ul><li><strong>Operating System</strong> deleted (<del><i>All</i></del>)</li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Open</i></li></ul><p>I've merged a part of the pull request 210 by Alister H., the one about selection color.<br />The other one (fill pattern in point markers), was not merged since Qt brush styles aren't suitable for printouts because they can't be scaled.</p>
<p>Marco H. wrote:</p>
<blockquote>
<p>I think it (Qt brush styles) should not be advertised and maybe even removed from the simple fill symbol renderer / widget. It is much better to use line pattern fill / point pattern fill symbol layer instead.<br />A cool possibility would be to embed a polygon symbol into the simple marker symbollayer and use that to draw the point fill (just like e.g. the point fill symbollayer embeds a point symbol). Like this, the user could choose any polygon fill for the point symbol.</p>
</blockquote>
<p>See <a class="external" href="https://github.com/qgis/Quantum-GIS/pull/210">https://github.com/qgis/Quantum-GIS/pull/210</a> for the complete discussion.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=357292012-10-06T00:13:40ZPirmin Kalberer
<ul><li><strong>Target version</strong> changed from <i>Version 2.0.0</i> to <i>Future Release - Nice to have</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=362952012-10-06T01:02:08ZAlister Hood
<ul></ul><p>Has it been decided to retain the old symbology (or just not to implement all the missing features in new symbology) for 2.0.0?<br />Or has this been shifted to 2.1.0 because it is marked as a feature, but it should be marked as a bug?</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=362972012-10-06T01:24:52ZPaolo Cavallinicavallini@faunalia.it
<ul><li><strong>Target version</strong> changed from <i>Future Release - Nice to have</i> to <i>Version 2.0.0</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=369872012-11-09T02:31:41ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Pull Request or Patch supplied</strong> changed from <i>No</i> to <i>Yes</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=369902012-11-09T04:20:23ZMarco Hugentoblermarco.hugentobler@sourcepole.ch
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>Pull Request or Patch supplied</strong> changed from <i>Yes</i> to <i>No</i></li></ul><p>Changing to patch supplied -> no, since the accepted parts of the patches have been applied.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=369912012-11-09T04:21:58ZMarco Hugentoblermarco.hugentobler@sourcepole.ch
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Open</i></li></ul><p>Ooops, status should not be closed</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=402802013-04-17T17:08:57ZMathieu Pellerin - nIRVnirvn.asia@gmail.com
<ul></ul><p>Since old symbology was removed, I'm wondering whether this issue will be fixed prior to 2.0 release.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=402862013-04-17T22:32:59ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>nirvn - wrote:</p>
<blockquote>
<p>Since old symbology was removed, I'm wondering whether this issue will be fixed prior to 2.0 release.</p>
</blockquote>
<p>missing features in new symbology available in old should be tagged as blockers. The issue is already on the "todo" list</p>
<p><a class="external" href="https://issues.qgis.org/wiki/17/Switching_from_Old_to_New_Symbology_and_Labeling">https://issues.qgis.org/wiki/17/Switching_from_Old_to_New_Symbology_and_Labeling</a></p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=480172014-01-30T22:43:35ZPaolo Cavallinicavallini@faunalia.it
<ul><li><strong>Target version</strong> changed from <i>Version 2.0.0</i> to <i>Future Release - High Priority</i></li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=505402014-05-02T19:56:25ZMathieu Pellerin - nIRVnirvn.asia@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>fixed/implemented</i></li></ul><p>It's done, wouhou.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=505842014-05-04T20:44:36ZAlister Hood
<ul></ul><p>Ummm. Why do you think this is fixed?<br />As far as I can tell we still have the same situation with fill styles (which Marco says are not actually suitable) available for polygons but not point symbols.<br />Or did you close it because you really just wanted the ability to have no fill, and you can do this by specifying 0 for the alpha channel?</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=505912014-05-04T23:09:36ZMathieu Pellerin - nIRVnirvn.asia@gmail.com
<ul></ul><p>Oups, Alister's right, this isn't fix; I got confused with the outline style vs fill style.</p>
<p>Could someone re-open this issue? It's a pretty important one.</p> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=505922014-05-04T23:13:41ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Open</i></li><li><strong>Resolution</strong> deleted (<del><i>fixed/implemented</i></del>)</li></ul> QGIS Application - Feature request #3430: fill pattern missing for point markers in new symbology enginehttps://issues.qgis.org/issues/3430?journal_id=709302016-06-16T00:26:07ZMathieu Pellerin - nIRVnirvn.asia@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>fixed/implemented</i></li></ul><p>Nyall's filled marker does exactly that, and then some :) closing, feature implemented.</p>