https://issues.qgis.org/https://issues.qgis.org/favicon.ico2009-12-19T16:09:57ZQGIS Issue TrackingQGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=206572009-12-19T16:09:57ZSteven Mizunospookster@netzero.net
<ul></ul><p>For me, this problem always occurs with the sequence of events noted.</p>
<p>I have noticed that the overview map is drawn at the same scale as the main map, which led me to believe that the cached image is used. I tested this by using map data that takes a noticeable amount of time to retrieve. The overview map is drawn almost instantly when the overview is enabled for the layer. Also noticed that the upper left area of the main map is what is shown in the overview, including the buffer around the 'full extent'.</p> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=206582010-12-07T09:07:03ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>it seems that is still true with the actual trunk .</p>
<p>After adding a layer it does not show in the overview window unless OTFR is activated. If you activate OTFR after having added the layer, then the overview show something but the canvas extent goes wild. In this case using "zoom to layer" does not help, it is needed to give a "touch" with the pan tool and the canvas extent return more or less normal.</p>
<p>If OTFR is activated before adding the layer (and adding it to the overview) then the overview shows the layer but very very small... basically useless... and there is no way to recover the situation, even trying with "zoom to layer" or other tools.</p>
<p>With render caching enabled the crashes when resizing the overview window are still confirmed... but this is another problem already described in another ticket.</p> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=206592010-12-07T09:20:30ZMartin Dobiaswonder.sk@gmail.com
<ul></ul><p>Can you please try it out with the threading branch? The render caching problems should be gone there.</p>
<p>(But there are still some bugs which prevent me from merging the branch to trunk)</p> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=206602010-12-07T09:23:29ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Hi Martin,</p>
<p>do I compile it as I do normally with trunk?</p> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=206612010-12-07T11:25:59ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Replying to [comment:4 wonder]:</p>
<blockquote>
<p>Can you please try it out with the threading branch?</p>
</blockquote>
<p>Hi Martin, confirmed, in the threading branch I don't see the problems described here and I don't get the crashes if resizing the overview window.</p>
<p>I really look forward for your commits fir this an many other reasons! thanks a lot.</p> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=253222011-07-25T07:14:27ZPaolo Cavallinicavallini@faunalia.it
<ul><li><strong>Tracker</strong> changed from <i>Bug report</i> to <i>4</i></li><li><strong>Assignee</strong> deleted (<del><i>nobody -</i></del>)</li><li><strong>Start date</strong> set to <i>2011-07-25</i></li><li><strong>Pull Request or Patch supplied</strong> set to <i>No</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=256322011-09-05T11:19:12ZSteven Mizunospookster@netzero.net
<ul><li><strong>File</strong> <a href="/attachments/download/3417/patch_for_2166_1449_2302.diff">patch_for_2166_1449_2302.diff</a><a href="/attachments/3417/patch_for_2166_1449_2302.diff"><img alt="Magnifier" src="/images/magnifier.png" /></a> added</li><li><strong>Pull Request or Patch supplied</strong> changed from <i>No</i> to <i>Yes</i></li></ul><p>Patch to fix <a class="issue tracker-1 status-5 priority-4 priority- closed" href="https://issues.qgis.org/issues/2166" title="with render caching enabled the overview goes wild when changing vector symbology (Closed)">#2166</a>, <a class="issue tracker-1 status-5 priority-3 priority- closed" href="https://issues.qgis.org/issues/1449" title="The map and overview canvas resizes incorrectly (Closed)">#1449</a>, <a class="issue tracker-1 status-5 priority-3 priority- closed" href="https://issues.qgis.org/issues/2302" title="render caching places map in wrong place when re-enabling (Closed)">#2302</a><br />related: <a class="issue tracker-1 status-5 priority-3 priority- closed" href="https://issues.qgis.org/issues/2038" title="Incremental rendering of features does not work when render cache is used (Closed)">#2038</a> about render caching disabling incremental drawing - I recommend WON'T FIX on this one; reason given below and in the ticket.</p>
<p>I am submitting fixes for several tickets as a single patch because I worked on them pretty much together as the problems seemed to be related.</p>
<p>I think the patch also fixes <a class="issue tracker-1 status-5 priority-4 priority- closed" href="https://issues.qgis.org/issues/4174" title="Rasters are not rendered again when changing project CRS with render caching enabled (Closed)">#4174</a>, but I was not able to reproduce the reported problem, so I am not sure what effect there is.</p>
The tickets referenced concern the interactions of the following:
<ul>
<li>render caching</li>
<li>on-the-fly reprojection</li>
<li>the 'Number of features to draw before updating the display' setting (incremental rendering)</li>
<li>window resizing - overview or main map</li>
</ul>
<p>None of the problems was particularly difficult to fix; what was hard was determining the exact situations that show the problems, then testing the fixes.</p>
The patch:
<ul>
<li>don't draw (redraw) overview if already drawing - this fixes the main complaint on <a class="issue tracker-1 status-5 priority-4 priority- closed" href="https://issues.qgis.org/issues/2166" title="with render caching enabled the overview goes wild when changing vector symbology (Closed)">#2166</a></li>
<li>don't remember last extent if not caching (see <a class="issue tracker-1 status-5 priority-3 priority- closed" href="https://issues.qgis.org/issues/2302" title="render caching places map in wrong place when re-enabling (Closed)">#2302</a>). The last extent is used only for caching purposes.</li>
<li>don't use the render cache for the overview - fixes 2 related issues, wrong cached image on overview or main map depending on which was last drawn, when making a layer visible - see <a class="issue tracker-1 status-5 priority-3 priority- closed" href="https://issues.qgis.org/issues/2302" title="render caching places map in wrong place when re-enabling (Closed)">#2302</a><br />Redrawing the overview isn't done nearly as often as main map, except on resizing, perhaps, so shouldn't be much of a performance issue.</li>
<li>set full extent for overview when resizing - see <a class="issue tracker-1 status-5 priority-3 priority- closed" href="https://issues.qgis.org/issues/1449" title="The map and overview canvas resizes incorrectly (Closed)">#1449</a> - complaint about overview (and main map) scale change on resize smaller</li>
<li>Disable incremental rendering if render caching is on by ignoring the setting. Incremental rendering makes no sense if Render caching is enabled (it actually does so, but to the cache image)<br />Disable the option in Settings, Options to make it obvious to user when Render caching is on.<br />Documentation should note this.</li>
<li>fix overview map for left mouse button press only (overlooked on a previous improvement I did) to be consistent with release and move events</li>
</ul>
<p>Note that the windowing system event handling may cause missed repaints (incomplete repaint of window) especially if a redraw takes a significant amount of time - this is true when both main map and overview are being drawn on resizing.<br />In testing I have found that resizing/repainting works fairly well for overview as long as Render is disabled. If Render is on, there is often no redraw of the overview or other parts of window, like dock widget title bars. <br />In particular, maximizing/restoring the main window will likely not redraw the overview and the main map draws after a long pause. This problem existed before the current changes.<br />This is the case even without these changes.</p>
<p>The only thing I can offer is that a manually forced redraw be done - for the overview, toggling a layer off, then on (either way actually). And, if necessary, refresh the map.</p>
<p>I have tested on Microsoft Windows, but not other platforms.</p>
Observations on incremental rendering:
<ul>
<li>if there is a rubberband or highlight object, rendering of the map is very slow - how slow depends on the complexity of the rubberband/highlight object (number of vertices) as the object is rendered each time the display is updated during layer rendering</li>
</ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=256332011-09-06T00:09:42ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Target version</strong> changed from <i>Version 1.7.0</i> to <i>Version 1.7.1</i></li><li><strong>Priority</strong> changed from <i>Low</i> to <i>Normal</i></li><li><strong>Assignee</strong> set to <i>Martin Dobias</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=263582011-11-12T04:52:12ZTim Suttontim@linfiniti.com
<ul><li><strong>Target version</strong> changed from <i>Version 1.7.1</i> to <i>Version 1.7.2</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=266142011-11-30T11:40:27ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Target version</strong> changed from <i>Version 1.7.2</i> to <i>Version 1.7.3</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=269582011-12-16T09:54:47ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Target version</strong> changed from <i>Version 1.7.3</i> to <i>Version 1.7.4</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=281252011-12-23T23:53:12ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Assignee</strong> deleted (<del><i>Martin Dobias</i></del>)</li><li><strong>Subject</strong> changed from <i>with render caching enabled the overview goes wild</i> to <i>with render caching enabled the overview goes wild when changing vector symbology</i></li></ul><p>The situation really improved:</p>
<p>the overview extent still goes wild when changing the vector symbology, but now resizing the overview window "fixes" the problem. Usually when resizing the overview windows the canvas is not drawn, forcing to click the "refresh" button, but it happens also if "render caching" is not enabled.</p>
<p>At least now the overview seems usable.</p>
<p>I don't know if this improvement is because a part of the attached patch was used.</p>
<p>Was the attached patch reviewd/commited? if no, why?</p> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=301972012-04-15T07:22:56ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Affected QGIS version</strong> set to <i>master</i></li><li><strong>Tracker</strong> changed from <i>4</i> to <i>Bug report</i></li><li><strong>Crashes QGIS or corrupts data</strong> set to <i>No</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=307982012-04-16T04:22:44ZPaolo Cavallinicavallini@faunalia.it
<ul><li><strong>Target version</strong> changed from <i>Version 1.7.4</i> to <i>Version 1.8.0</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=346412012-09-04T10:01:57ZPaolo Cavallinicavallini@faunalia.it
<ul><li><strong>Target version</strong> changed from <i>Version 1.8.0</i> to <i>Version 2.0.0</i></li></ul> QGIS Application - Bug report #2166: with render caching enabled the overview goes wild when changing vector symbologyhttps://issues.qgis.org/issues/2166?journal_id=377052012-12-13T13:11:32ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Resolution</strong> set to <i>fixed</i></li><li><strong>Status info</strong> deleted (<del><i>0</i></del>)</li><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>Operating System</strong> deleted (<del><i>All</i></del>)</li></ul><p>This issue seems gobe in qgis master. Please reopen if necessary.</p>