https://issues.qgis.org/https://issues.qgis.org/favicon.ico2018-12-12T16:32:58ZQGIS Issue TrackingQGIS Application - Bug report #20789: Check Geometries causes crash on 3.4.2 and Master https://issues.qgis.org/issues/20789?journal_id=972222018-12-12T16:32:58ZAlessandro Pasotti
<ul><li><strong>Assignee</strong> set to <i>Alessandro Pasotti</i></li></ul><p>Confirmed</p> QGIS Application - Bug report #20789: Check Geometries causes crash on 3.4.2 and Master https://issues.qgis.org/issues/20789?journal_id=972232018-12-12T17:03:46ZAlessandro Pasotti
<ul></ul><p>I've found the bug that caused the crash (and what a big one!!) but the tool is still unusable with a big layer: it uses a feature cache (with an hardcoded size of 1000) and because the cache gets filled in a blink of an eye all the operations are slowed down by the cache trimming and insertion.</p>
<p>I have a 32 GB RAM and 16 CPU cores machine and this is taking a loooong time (61% after half an hour, no crashes so far).</p> QGIS Application - Bug report #20789: Check Geometries causes crash on 3.4.2 and Master https://issues.qgis.org/issues/20789?journal_id=972242018-12-12T17:55:40ZAlessandro Pasotti
<ul><li><strong>Pull Request or Patch supplied</strong> changed from <i>No</i> to <i>Yes</i></li></ul><p>This fixes the crash (and probably many more bugs) <a class="external" href="https://github.com/qgis/QGIS/pull/8660">https://github.com/qgis/QGIS/pull/8660</a></p>
<p>As I mentioned, the tool is almost unusable (too slow) with large layers (but that's another issue).</p> QGIS Application - Bug report #20789: Check Geometries causes crash on 3.4.2 and Master https://issues.qgis.org/issues/20789?journal_id=972252018-12-12T17:55:49ZAlessandro Pasotti
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>In Progress</i></li></ul> QGIS Application - Bug report #20789: Check Geometries causes crash on 3.4.2 and Master https://issues.qgis.org/issues/20789?journal_id=972282018-12-12T20:27:58ZAntonio Viscomiantoviscomi@gmail.com
<ul></ul><p>Alessandro Pasotti wrote:</p>
<blockquote>
<p>I've found the bug that caused the crash (and what a big one!!) but the tool is still unusable with a big layer: it uses a feature cache (with an hardcoded size of 1000) and because the cache gets filled in a blink of an eye all the operations are slowed down by the cache trimming and insertion.</p>
<p>I have a 32 GB RAM and 16 CPU cores machine and this is taking a loooong time (61% after half an hour, no crashes so far).</p>
</blockquote>
<p>Great! Alessandro, <br />Thanks a lot for your job</p>
<p>Cheers</p> QGIS Application - Bug report #20789: Check Geometries causes crash on 3.4.2 and Master https://issues.qgis.org/issues/20789?journal_id=972342018-12-13T07:14:30ZAlessandro Pasotti
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/b0d1506b7205ebf29fa8348379f7fa85def49595" title="Fix QgsReadWriteLocker changeMode since mMode was never updated, the lock was never toggled from...">qgis|b0d1506b7205ebf29fa8348379f7fa85def49595</a>.</p> QGIS Application - Bug report #20789: Check Geometries causes crash on 3.4.2 and Master https://issues.qgis.org/issues/20789?journal_id=972882018-12-17T09:47:35ZJürgen Fischerjef@norbit.de
<ul><li><strong>Duplicated by</strong> <i><a class="issue tracker-1 status-1 priority-5 priority-" href="/issues/20791">Bug report #20791</a>: On the fly geometry validation doesn't work and causes QGIS to not respond</i> added</li></ul>