https://issues.qgis.org/https://issues.qgis.org/favicon.ico2018-09-06T09:30:19ZQGIS Issue TrackingQGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926042018-09-06T09:30:19ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><p>Please attach sample data.<br />Does works as expected on 2.18?</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926082018-09-06T09:48:09Zna na
<ul><li><strong>File</strong> <a href="/attachments/download/13255/Polygon%20with%20thin%20ring.zip">Polygon with thin ring.zip</a> added</li></ul><p>Giovanni Manghi wrote:</p>
<blockquote>
<p>Please attach sample data.<br />Does works as expected on 2.18?</p>
</blockquote>
<p>Does not work as expected on 2.18.22 or 2.18.23<br />Sorry have attached shp files as zip file for Tests 1, 1b and probably Test 3<br />The shp files for Test 2 would be difficult to upload.</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926092018-09-06T09:53:31Zna na
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li></ul> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926102018-09-06T09:58:11ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Priority</strong> changed from <i>High</i> to <i>Normal</i></li><li><strong>Regression?</strong> changed from <i>Yes</i> to <i>No</i></li></ul> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926162018-09-06T10:09:28ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Tom T wrote:</p>
<blockquote>
<p>Giovanni Manghi wrote:</p>
<blockquote>
<p>Please attach sample data.<br />Does works as expected on 2.18?</p>
</blockquote>
<p>Does not work as expected on 2.18.22 or 2.18.23<br />Sorry have attached shp files as zip file for Tests 1, 1b and probably Test 3<br />The shp files for Test 2 would be difficult to upload.</p>
</blockquote>
<p>I downloaded the dataset, is empty.</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926212018-09-06T11:08:44Zna na
<ul><li><strong>File</strong> <a href="/attachments/download/13256/Polygon%20with%20thin%20ring_USE%20THIS.zip">Polygon with thin ring_USE THIS.zip</a> added</li></ul><p>Giovanni Manghi wrote:</p>
<blockquote>
<p>Tom T wrote:</p>
<blockquote>
<p>Giovanni Manghi wrote:</p>
<blockquote>
<p>Please attach sample data.<br />Does works as expected on 2.18?</p>
</blockquote>
<p>Does not work as expected on 2.18.22 or 2.18.23<br />Sorry have attached shp files as zip file for Tests 1, 1b and probably Test 3<br />The shp files for Test 2 would be difficult to upload.</p>
</blockquote>
<p>I downloaded the dataset, is empty.</p>
</blockquote>
<p>Sorry, Corrected file attached, annoyed as I should have spotted that.<br />Shp files generated from QGIS 2.18.22</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926262018-09-06T13:03:45ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><blockquote>
<p>Sorry, Corrected file attached, annoyed as I should have spotted that.<br />Shp files generated from QGIS 2.18.22</p>
</blockquote>
<p>I zoomed in enough to see the hole, clicking in with the tool and is gone.</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=926852018-09-10T09:52:25Zna na
<ul><li><strong>File</strong> <a href="/attachments/download/13268/Picture%20E%20view%20of%20the%20thin%20rings%20on%20a%20modified%20shp%20file.PNG">Picture E view of the thin rings on a modified shp file.PNG</a> added</li><li><strong>File</strong> <a href="/attachments/download/13267/Modified%20shp%20file%20for%20Test%202.zip">Modified shp file for Test 2.zip</a> added</li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li></ul><p>Ok, though there are normally more than 1 thin ring at one time. I think it is impractical to zoom in on each ring in order to delete the rings. I would think that users work on multiple polygons, shapes at any one time? I think we need the delete ring tool to work on larger scales when you can see multiple polygons ect... see Picture E view of the thin rings on a modified shp file.</p>
<p>I was trying to replicate "thin rings" using add ring button, (which is still a bug for the delete ring button at larger scales)</p>
<p>I have modified the file I used for Test 2 (Modified shp file for Test 2.zip)<br />This is the file where I found rings after merging polygons together. I think rings generated from I think from poor splitting of polygons with incorrect snapping options enabled.<br />This Modified shp file for Test 2 should give a better example file, I can't zoom in and delete the rings, at least in QGIS 2.18.22<br />If you see any personal information please delete this zip, but I believe there shouldn't be any personal information on these files.</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=927372018-09-11T11:59:05ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><p>Tom T wrote:</p>
<blockquote>
<p>Ok, though there are normally more than 1 thin ring at one time. I think it is impractical to zoom in on each ring in order to delete the rings. I would think that users work on multiple polygons, shapes at any one time? I think we need the delete ring tool to work on larger scales when you can see multiple polygons ect... see Picture E view of the thin rings on a modified shp file.</p>
<p>I was trying to replicate "thin rings" using add ring button, (which is still a bug for the delete ring button at larger scales)</p>
<p>I have modified the file I used for Test 2 (Modified shp file for Test 2.zip)<br />This is the file where I found rings after merging polygons together. I think rings generated from I think from poor splitting of polygons with incorrect snapping options enabled.<br />This Modified shp file for Test 2 should give a better example file, I can't zoom in and delete the rings, at least in QGIS 2.18.22<br />If you see any personal information please delete this zip, but I believe there shouldn't be any personal information on these files.</p>
</blockquote>
<p>this digitizing tools is there specifically to allow remove by hand one by one those rings. If you need to remove a bunch of them you can use the "delete holes" tool in the Processing toolbox. If you get them by dissolving features that should be adjacent but they are not, then use the GRASS dissolve tool and its advanced option "snapping".</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=927472018-09-11T13:55:23Zna na
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li></ul><p>Giovanni Manghi wrote:</p>
<blockquote>
<p>Tom T wrote:</p>
<blockquote>
<p>Ok, though there are normally more than 1 thin ring at one time. I think it is impractical to zoom in on each ring in order to delete the rings. I would think that users work on multiple polygons, shapes at any one time? I think we need the delete ring tool to work on larger scales when you can see multiple polygons ect... see Picture E view of the thin rings on a modified shp file.</p>
<p>I was trying to replicate "thin rings" using add ring button, (which is still a bug for the delete ring button at larger scales)</p>
<p>I have modified the file I used for Test 2 (Modified shp file for Test 2.zip)<br />This is the file where I found rings after merging polygons together. I think rings generated from I think from poor splitting of polygons with incorrect snapping options enabled.<br />This Modified shp file for Test 2 should give a better example file, I can't zoom in and delete the rings, at least in QGIS 2.18.22<br />If you see any personal information please delete this zip, but I believe there shouldn't be any personal information on these files.</p>
</blockquote>
<p>this digitizing tools is there specifically to allow remove by hand one by one those rings. If you need to remove a bunch of them you can use the "delete holes" tool in the Processing toolbox. If you get them by dissolving features that should be adjacent but they are not, then use the GRASS dissolve tool and its advanced option "snapping".</p>
</blockquote>
<p>*Edit Grammar</p>
<p>Thanks, I see what you are saying, though I disagree a bit. Have you had any success deleting the thin rings using the Delete Ring Button for this ERSI shape file: modified shp file for Test 2?</p>
<p>I would like to keep multiple ways of deleting rings/thin rings at various/larger scales, like I think we can with other functions.<br />I like the ability to just quickly delete the rings I find on a one to one basis (large scales) on the occasion I merge some polygons together on a layer. This avoids create new layers using Processing Toolbox, Delete Rings.</p>
<p>This is partly because I think explaining how to use/using the delete ring tool to users is easier than how to use GRASS.<br />Though using the Processing Toolbox, Delete Rings is reasonably easy to explain/and I assume use. :-)</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=927502018-09-11T14:08:05ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><blockquote>
<p>Have you had any success deleting the thin rings using the Delete Ring Button for this ERSI shape file: modified shp file for Test 2?</p>
</blockquote>
<p>yes</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=927542018-09-11T15:20:40Zna na
<ul></ul><p>Giovanni Manghi wrote:</p>
<blockquote><blockquote>
<p>Have you had any success deleting the thin rings using the Delete Ring Button for this ERSI shape file: modified shp file for Test 2?</p>
</blockquote>
<p>yes</p>
</blockquote>
<p>Could you please explain how?<br />Using these files, I can't delete the rings using the delete ring button on QGIS 3.2.2-1, you zoom in to 25:1 or so, I can't delete a ring.<br />Enabled snapping by default in Setting, Options, Digitizing<br />Hopefully I am not drawing this conversation out too much. Thanks</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=927922018-09-12T14:33:16ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Tom T wrote:</p>
<blockquote>
<p>Giovanni Manghi wrote:</p>
<blockquote><blockquote>
<p>Have you had any success deleting the thin rings using the Delete Ring Button for this ERSI shape file: modified shp file for Test 2?</p>
</blockquote>
<p>yes</p>
</blockquote>
<p>Could you please explain how?</p>
</blockquote>
<p>the tool works when clicking on the "area" of a hole... so just use the node to move one of the nodes, expose the hole "area" and use the delete hole tool.</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=927932018-09-12T14:56:10Zna na
<ul></ul><p>Giovanni Manghi wrote:</p>
<blockquote>
<p>Tom T wrote:</p>
<blockquote>
<p>Giovanni Manghi wrote:</p>
<blockquote><blockquote>
<p>Have you had any success deleting the thin rings using the Delete Ring Button for this ERSI shape file: modified shp file for Test 2?</p>
</blockquote>
<p>yes</p>
</blockquote>
<p>Could you please explain how?</p>
</blockquote>
<p>the tool works when clicking on the "area" of a hole... so just use the node to move one of the nodes, expose the hole "area" and use the delete hole tool.</p>
</blockquote>
<p>Thanks for clarifying, though my bug still exists. My bug is about not being able to delete thin rings/0/small areas.</p>
<p>I think the tool has generally worked if you can see an "area" of a hole. I have done "the tool works when clicking on the "area" of a hole... so just use the node to move one of the nodes, expose the hole "area" and use the delete hole tool." in the past.</p>
<p>If the tool won't delete thin rings, we will just need to use the node tool. <strong>Just seems silly that the delete ring tool can't delete thin rings (islands) though, hence my bug request.</strong> Thanks</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=927942018-09-12T15:06:35ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><blockquote>
<p>Thanks for clarifying, though my bug still exists. My bug is about not being able to delete thin rings/0/small areas.</p>
</blockquote>
<p>if you don't want to zoom like crazy and use the delete ring tool (That works for me) use the proposed workaround.<br />To remove batched of zero areas rings/polygons use automated tools</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=928362018-09-14T12:32:23Zna na
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li></ul><p>Giovanni Manghi wrote:</p>
<blockquote><blockquote>
<p>Thanks for clarifying, though my bug still exists. My bug is about not being able to delete thin rings/0/small areas.</p>
</blockquote>
<p>if you don't want to zoom like crazy and use the delete ring tool (That works for me) use the proposed workaround.<br />To remove batched of zero areas rings/polygons use automated tools</p>
</blockquote>
<p>Yeah... :-) I just disagree a bit, I don't think you should need to modify the thin ring using the node tool for the delete ring to work.<br />As stated before: I would like to keep multiple ways of deleting rings/thin rings at various/larger scales, like I think we can with other functions.<br />I like the ability to just quickly delete the rings I find on a one to one basis (large scales) on the occasion I merge some polygons together on a layer. This avoids create new layers using Processing Toolbox, Delete Rings.</p>
<p>Though this is an open source program, so I would need to build support for fixing this, as I'm not the one doing the work! :-) However I think other users could/do agree with me, there is a stackexchange ticket saying that the ring tool isn't working.<br />Thanks</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=928392018-09-14T16:28:12ZHarrissou Santanna
<ul></ul><blockquote>
<p>However I think other users could/do agree with me, there is a stackexchange ticket saying that the ring tool isn't working.</p>
</blockquote>
<p>/me cheeky. It's not because it's said on stackExchange that it's true. And I do not agree that it's not working; it works the way it's designed. The "Delete ring" tool requires you to click within the ring to get it removed. This means that on thin rings you need to enlarge the rings and then delete them. Which I fully agree is not optimal and a real waste of time.<br />Maybe It could be improved so that it removes rings that are within a certain tolerance of the clicked coordinate? A feature request?</p>
<p>Meanwhile, Tom, another workaround can be to draw a rough polygon that covers the ring but still within the main polygon and merge both later...</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=928432018-09-14T16:36:16ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><p>Harrissou Santanna wrote:</p>
<blockquote>
<p>This means that on thin rings you need to enlarge the rings and then delete them. Which I fully agree is not optimal and a real waste of time.</p>
</blockquote>
<p>I ALSO agree, but please notice that on older QGIS releases the worked when clicking on the boundaries of the hole, not inside the hole itself. This was ALSO considered cumbersome by many, so it was changed.</p>
<p>I guess that this ticket should really become a feature request asking to restore the old way to work, or implement both.</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=936762018-10-01T08:34:02Zna na
<ul></ul><p>Harrissou Santanna wrote:</p>
<blockquote>
<p>Meanwhile, Tom, another workaround can be to draw a rough polygon that covers the ring but still within the main polygon and merge both later...</p>
</blockquote>
<p>Thank you, I see what you mean about the "way it is designed"</p>
<p>Giovanni Manghi wrote:</p>
<blockquote>
<p>Harrissou Santanna wrote:</p>
<blockquote>
<p>This means that on thin rings you need to enlarge the rings and then delete them. Which I fully agree is not optimal and a real waste of time.</p>
</blockquote>
<p>I ALSO agree, but please notice that on older QGIS releases the worked when clicking on the boundaries of the hole, not inside the hole itself. This was ALSO considered cumbersome by many, so it was changed.</p>
<p>I guess that this ticket should really become a feature request asking to restore the old way to work, or implement both.</p>
</blockquote>
<p>Can we implement both to make users who want both functionality? Or maybe have 2 delete ring tools, One "Delete Ring" (click inside hole) and "Delete line Ring" (click on boundaries)<br />I can change this to a feature requests if that helps?</p> QGIS Application - Feature request #19784: make the "Delete Ring" Tool work also by clicking on the ring boundarieshttps://issues.qgis.org/issues/19784?journal_id=936902018-10-01T15:46:38ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Subject</strong> changed from <i>Delete Ring Tool not working on thin rings</i> to <i>make the "Delete Ring" Tool work also by clicking on the ring boundaries</i></li><li><strong>Tracker</strong> changed from <i>Bug report</i> to <i>Feature request</i></li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li></ul>