https://issues.qgis.org/
https://issues.qgis.org/favicon.ico
2016-11-10T07:17:20Z
QGIS Issue Tracking
QGIS Application - Bug report #15829: georeferencer - logical error during loadGCPs
https://issues.qgis.org/issues/15829?journal_id=73377
2016-11-10T07:17:20Z
Mark Johnson
mj10777@googlemail.com
<ul></ul><p>This could then be something in the form of:</p>
<pre>
bool QgsGeorefPluginGui::loadGCPs( /*bool verbose*/ )
{
QFile pointFile( mGCPpointsFileName );
if ( !pointFile.open( QIODevice::ReadOnly ) )
{
return false;
}
clearGCPData();
QTextStream points( &pointFile );
QString line = points.readLine();
while ( !points.atEnd() )
{
...
QgsPoint mapCoords( ls.at( 0 ).toDouble(), ls.at( 1 ).toDouble() ); // map x,y
QgsPoint pixelCoords( ls.at( 2 ).toDouble(), ls.at( 3 ).toDouble() ); // pixel x,y
QgsGeorefDataPoint* pnt;
if ( ls.count() == 5 )
{
bool enable = ls.at( 4 ).toInt();
pnt = new QgsGeorefDataPoint( mCanvas, mIface->mapCanvas(), pixelCoords, mapCoords, enable);
}
else
pnt = new QgsGeorefDataPoint( mCanvas, mIface->mapCanvas(), pixelCoords, mapCoords,true);
mPoints.append( pnt );
connect( mCanvas, SIGNAL( extentsChanged() ), pnt, SLOT( updateCoords() ) );
++i;
}
mInitialPoints = mPoints;
mGCPsDirty = true;
}
if ( mGCPsDirty )
{
mGCPListWidget->setGCPList( &mPoints );
updateGeorefTransform();
mCanvas->refresh();
mIface->mapCanvas()->refresh();
}
return true;
}
</pre>
QGIS Application - Bug report #15829: georeferencer - logical error during loadGCPs
https://issues.qgis.org/issues/15829?journal_id=73381
2016-11-10T14:43:22Z
Nyall Dawson
<ul></ul><p>Mark - this looks good! Could you submit this as a pull request to the QGIS Github repo (<a class="external" href="https://github.com/qgis/QGIS">https://github.com/qgis/QGIS</a>)? That's the usual approach to get changes like this merged in.</p>
QGIS Application - Bug report #15829: georeferencer - logical error during loadGCPs
https://issues.qgis.org/issues/15829?journal_id=73391
2016-11-11T08:18:48Z
Mark Johnson
mj10777@googlemail.com
<ul></ul><p>Done, see:</p>
<p><a class="external" href="https://github.com/qgis/QGIS/pull/3754">https://github.com/qgis/QGIS/pull/3754</a></p>
<p>please see the notes of the pull, since other files diff have been included.</p>
QGIS Application - Bug report #15829: georeferencer - logical error during loadGCPs
https://issues.qgis.org/issues/15829?journal_id=73533
2016-12-04T16:21:59Z
Mark Johnson
mj10777@googlemail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Fixed in changeset <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/59a0e2fb886fc0bcf620c860bba85d3863c46b73" title="Fix #15829 georeferencer - resolve logical error during loadGCPs">59a0e2fb886fc0bcf620c860bba85d3863c46b73</a>.</p>