https://issues.qgis.org/https://issues.qgis.org/favicon.ico2015-07-28T16:21:49ZQGIS Issue TrackingQGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629782015-07-28T16:21:49ZLene Fischerlfi@ign.ku.dk
<ul></ul><p>Using other functions from Geoprocession tool: Intersection and Clip - The new layer come out empty.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629792015-07-28T16:43:13ZLene Fischerlfi@ign.ku.dk
<ul></ul><p>Just tried the same functions in 2.8.2 - where they work fine.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629822015-07-30T11:04:48ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Subject</strong> changed from <i>Dissolve delete polygons</i> to <i>ftools dissolve, intersection, clip broken</i></li><li><strong>Priority</strong> changed from <i>High</i> to <i>Severe/Regression</i></li><li><strong>Target version</strong> changed from <i>Version 2.10</i> to <i>Future Release - High Priority</i></li></ul> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629832015-07-30T11:18:04ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><p>Hi Lene,</p>
<p>could you provide sample data? I cannot replicate here (Win 7 64 bit, qgis 2.10.1/osgeo4w).</p>
<p>About the slowness:</p>
<p>the QGIS geoprocessing tools are unfortunately historically slow and often unreliable (without forgetting the often they break from one release to another). Honestly it seems at least strange that among all the (new) cool features regularly added (or fixed) no one has ever felt the necessity to have them ported rewritten (maybe in C++) to make them robust, faster and returning right results.</p>
<p>I soon plan to add in Processing new geoprocessing tools (a few are already available, clip, dissolve) based on ogr2ogr and SQL, so at least reliable alternative will be avalable without needing to use GRASS or SAGA tools.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629862015-07-30T11:32:04ZLene Fischerlfi@ign.ku.dk
<ul><li><strong>File</strong> <a href="/attachments/download/8954/polygons.zip">polygons.zip</a> added</li></ul><p>Hi Giovanni,<br />Exampledata added.</p>
<p>Bo Thomsen tried the last build 2.10.1 and 2.11 OSGEO 64 bit (Win 10) - with same result.</p>
<p>Regards<br />Lene</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629932015-07-30T11:58:07ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Hi Lene,</p>
<p>what is the field to be used for the dissolve? there are many in the table of attributes. Thanks.</p>
<p>Lene Fischer wrote:</p>
<blockquote>
<p>Hi Giovanni,<br />Exampledata added.</p>
<p>Bo Thomsen tried the last build 2.10.1 and 2.11 OSGEO 64 bit (Win 10) - with same result.</p>
<p>Regards<br />Lene</p>
</blockquote> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629942015-07-30T11:59:29ZLene Fischerlfi@ign.ku.dk
<ul></ul><p>Try "Regionnavn"</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=629952015-07-30T12:02:19ZGiovanni Manghigiovanni.manghi@gmail.com
<ul><li><strong>Category</strong> set to <i>44</i></li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li></ul><p>confirmed.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=637522015-09-21T05:24:16ZBernhard Ströblbernhard.stroebl@jena.de
<ul><li><strong>Category</strong> changed from <i>44</i> to <i>Data Provider/OGR</i></li></ul>I checked with <em>Dissolve</em> in Processing in current master on Ubuntu;<br />result: in OGR-log there is an entry <code>Feature geometry not imported (OGR error: )</code> Thus the geometry of the new feature cannot be set, resulting in an empty layer.<br />Investigating further I discovered your layer is wkb-Type -2147483645 (wkbPolygon25D) <a class="external" href="http://gdal.org/java/constant-values.html">http://gdal.org/java/constant-values.html</a><br />Obviously QGIS (or OGR) cannot handle this type. If I create a new polygon shape file and copy your polygons over into the new layer, it is wkbType 3 (Polygon) and dissolves without any problems.<br />So the problem is not the algorithm but your data. However QGIS/Processing does not give any feedback stating the data is not suited.<br />Things to be done:
<ol>
<li>improve the OGR-error log stating the error</li>
<li><strong>either</strong> insert a geometry check so Processing only processes proper wkbTypes and gives feedback otherwise (Victor?)</li>
<li><strong>or</strong> improve QGIS' geometry handling, if not already in the pipeline (Marco?)</li>
</ol> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639542015-09-30T11:58:25ZMichele Mor
<ul></ul><p>Hi.<br />I have reported a similar issue using dissolve and if I process my shape file using 2.8.3 everything works, if I process the same file using 2.10.1 it does not work.<br />Unfortunately I cannot upload the shape file.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639672015-09-30T20:40:52ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>Hi,<br />can you load the layer, make it active and enter in the Python console<br /><code>iface.activeLayer().wkbType()</code><br />What is the result?</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639762015-09-30T23:04:40ZMichele Mor
<ul></ul><p>Hi Bernhard,</p>
<p><cite>can you load the layer, make it active and enter in the Python console<br />iface.activeLayer().wkbType()</cite></p>
<p>if I have done it correctly (never used the python console before), my result is 3.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639772015-09-30T23:40:48ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>wkbType 3 is a straight polygon layer, different from Lene's and should work (according to what we know until now). If you cannot share the shape file publicly you might want to provide it to me for testing.<br />Could you describe what your result is or (better) if you already opened a ticket link to it?</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639782015-10-01T02:32:34ZMichele Mor
<ul></ul><p>Hi Bernhard.<br />I have tried to reproduce the same error using a sample file but it works!<br />The file that I use is the Codepoint with Polygons, but they are copyrighted therefore I cannot send you a copy (see: <a class="external" href="https://www.ordnancesurvey.co.uk/business-and-government/products/code-point-with-polygons.html">https://www.ordnancesurvey.co.uk/business-and-government/products/code-point-with-polygons.html</a>).</p>
<p>The whole file consist of 1.5 millions features and the shape file is almost 1.4GB.</p>
<p>If it's possible I could run the process again with some LOG or DEBUG options?</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639802015-10-01T03:04:33ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>This is a really large file, does it work with subsets of polygons (like 100000)<br />Are you using Processing 2.10.2? Maybe your computer runs out of memory, do you get an error message?</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639822015-10-01T03:44:17ZMichele Mor
<ul></ul><p>Hi.<br />I am using 2.10.1.<br />I have checked yesterday and that was the version available on the website.</p>
<p>The same file, same computer does not run out of memory with 2.8.3, therefore I assume that the new version is at fault (but I could be wrong!).<br />I don't have any error message, the new shape file is smaller than it should be and if I open it nothing happens.<br />I can take a screenshot and upload screenshots.<br />I will try to find the time for testing 100,000 polygons.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639832015-10-01T05:08:37ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>I meant the version of the <strong>Processing plugin</strong>, not QGIS, AFAIK you can update Processing independently of QGIS, although it is shipped with QGIS in the first place<br />All I konow is that when I install Processing 2.10.2 my recent changes to Dissolve are included. The former Dissolve took ages to run (when you used a dissolve field).</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639872015-10-01T07:18:39ZMichele Mor
<ul><li><strong>File</strong> <a href="/attachments/download/9131/Dissolve_process-End.png">Dissolve_process-End.png</a> added</li></ul><p>Hi.<br />Sorry for the misunderstanding, but I was not aware of the Processing Plugin.<br />The version installed was 2.10.99, so I downgraded to 2.10.2.<br />I have tried again and had the same issue.</p>
<p>I have attached a screenshot.<br />As you can see, first of all as soon as I click "OK" the path to destination file becomes blank.<br />Then, at the end of the process, even if the option to "add result to canvas" is selected, no layer is added.<br />If I look in the folder, my new shape file exists but if compared to successfull process is smaller 27M vs 45M.<br />I have tried to open the DBF file using another software and I had an error.</p>
<p>I will try to test using 100000 polygons tomorrow.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639932015-10-01T21:02:34ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>Please try with 100000 (or a selection) and report back.<br />I will be abroad for two weeks beginning this afternoon, so do not wonder when I do not answer.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=639972015-10-01T23:47:21ZMichele Mor
<ul></ul><p>Hi.<br />I have tried a sample using 194997 polygons and they were successfully dissolved into 1342 polygons.<br />I will try with a bigger sample and let you know when it fails.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=640042015-10-02T01:01:02ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>ok, could be a memory problem. Are you using a dissolve field? If yes: is it faster than in QGIS 2.8?</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=640052015-10-02T01:18:10ZMichele Mor
<ul></ul><p>Hi.<br />I am using a dissolve field. Don't know if it is faster than QGIS 2.8, never timed them because it takes around 20/30 mins so I tend to start the process and check once in a while.<br />Is there a log that I can check and see how long it took?</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=640062015-10-02T01:41:46ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>It <strong>should</strong> be faster. I tested with ~16000 polygons and the new algorithm takes a blink whereas it used to be minutes before. In processing history it is listed, when a process started. I do not know if there is more logging.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=640082015-10-02T03:08:39ZMichele Mor
<ul></ul><p>Hi, I did a couple of tests: with 221739 polygons success, with 798145 polygons failure.<br />I can check the speed of the same process in QGIS 2.8 and QGIS 2.10, but frankly I'm not concerned about it.<br />Unless I can give you more details or help - I could install a test version of QGIS if needed - I'm not spending more time on it.<br />To me it's an issue cause by the number of polygons and hopefully you can replicate it easily.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=648122015-10-22T04:46:57ZBernhard Ströblbernhard.stroebl@jena.de
<ul></ul><p>Currently my recent changes are reverted, so in the next version of QGIS Dissolve should behave as in 2.8</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=649102015-10-28T01:31:55ZMichele Mor
<ul></ul><p>Hi.<br />I have just downloaded and installed 2.12.0 Lyon.<br />The same layer that I can dissove with 2.8.3 fails in 2.12.0.<br />In the python panel I had the following error:<br />2015-10-27T16:06:05 1 Traceback (most recent call last):<br /> File "C:\\PROGRA~1\\QGISLY~1\\apps\\qgis\\python\\plugins\\fTools\\tools\\doGeoprocessing.py", line 309, in run<br /> geos, feature, match, error = self.dissolve(useField)<br /> File "C:\\PROGRA~1\\QGISLY~1\\apps\\qgis\\python\\plugins\\fTools\\tools\\doGeoprocessing.py", line 749, in dissolve<br /> feature.setGeometry(outFeats[k])<br /> TypeError: QgsFeature.setGeometry(QgsGeometry): argument 1 has unexpected type 'NoneType'</p>
<p>The other part of the panel is:<br />2015-10-27T16:06:05 1 An error has occured while executing Python code:</p>
<pre><code>TypeError: QgsFeature.setGeometry(QgsGeometry): argument 1 has unexpected type 'NoneType'</code></pre>
<pre><code>Traceback (most recent call last):<br /> File "C:\\PROGRA~1\\QGISLY~1\\apps\\qgis\\python\\plugins\\fTools\\tools\\doGeoprocessing.py", line 309, in run<br /> geos, feature, match, error = self.dissolve(useField)<br /> File "C:\\PROGRA~1\\QGISLY~1\\apps\\qgis\\python\\plugins\\fTools\\tools\\doGeoprocessing.py", line 749, in dissolve<br /> feature.setGeometry(outFeats[k])<br /> TypeError: QgsFeature.setGeometry(QgsGeometry): argument 1 has unexpected type 'NoneType'</code></pre>
<pre><code>Python version: 2.7.5 (default, May 15 2013, 22:44:16) [MSC v.1500 64 bit (AMD64)]</code></pre>
<pre><code>QGIS version: 2.12.0-Lyon Lyon, cd9d645</code></pre>
<pre><code>Python Path:</code></pre>
<pre><code>C:/Users/administrator/.qgis2/python/plugins\\processingC:/PROGRA~1/QGISLY~1/apps/qgis/./pythonC:/Users/administrator/.qgis2/pythonC:/Users/administrator/.qgis2/python/pluginsC:/PROGRA~1/QGISLY~1/apps/qgis/./python/pluginsC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\matplotlib-1.3.1-py2.7-win-amd64.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\<br />ose-1.3.3-py2.7.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\tornado-4.0.1-py2.7-win-amd64.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\backports.ssl_match_hostname-3.4.0.2-py2.7.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\certifi-14.05.14-py2.7.eggC:\\PROGRA~1\\QGISLY~1\\bin\\python27.zipC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\DLLsC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\libC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\plat-winC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\lib-tkC:\\PROGRA~1\\QGISLY~1\\binC:\\PROGRA~1\\QGISLY~1\\apps\\Python27C:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packagesC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\PILC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\jinja2-2.7.2-py2.7.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\markupsafe-0.23-py2.7-win-amd64.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\pytz-2012j-py2.7.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\win32C:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\win32\\libC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\PythonwinC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\Shapely-1.2.18-py2.7-win-amd64.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\six-1.3.0-py2.7.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\wx-2.8-msw-unicodeC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\xlrd-0.9.2-py2.7.eggC:\\PROGRA~1\\QGISLY~1\\apps\\Python27\\lib\\site-packages\\xlwt-0.7.5-py2.7.eggC:/Users/administrator/.qgis2//pythonC:\\PROGRA~1\\QGISLY~1\\apps\\qgis\\python\\plugins\\fTools\\tools</code></pre>
<p>Obviously I don't know if that caused the process to fails or is a red herring and the process failed because of memory issues.</p> QGIS Application - Bug report #13167: ftools dissolve, intersection, clip brokenhttps://issues.qgis.org/issues/13167?journal_id=677492016-01-29T08:29:27ZAlexander Bruy
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>fixed/implemented</i></li></ul><p>Vector geoprocessing tools now show error message if input layer has incompatible geometry type. As this was the problem of the original bugreport I close this. Please open new tickets for other issues if necessary.</p>