https://issues.qgis.org/https://issues.qgis.org/favicon.ico2015-06-23T11:54:32ZQGIS Issue TrackingQGIS Application - Bug report #13033: Data defined settings at root Marker are copied to child Symbol Layer itemshttps://issues.qgis.org/issues/13033?journal_id=626422015-06-23T11:54:32ZRegis Haubourgregis.haubourg@oslandia.com
<ul><li><strong>Assignee</strong> set to <i>Nyall Dawson</i></li></ul><p>Hi, putting Nyall in the list, he reviewed the code from Vincent Mora (I funded that feature).</p>
<p>In fact, old implementation was also confusing, using root level size as a multiplicator of size advanced field/expression. Each symbol did that too, and we had some bad interactions between expression and scaling method (area was still used when defining an expression). <br />The idea here was to define a more user friendly expression, on root level so that common users use that. There is an assistant now for size varying, that allows to generate a legend too. Much more consistent, and using same expression widgets as in labeling GUI.</p>
<p>Adding a new symbol should indeed keep scaling applied, you are right. Having only a scaling factor on root level does not seem quite clear to me. Other opinions ?</p> QGIS Application - Bug report #13033: Data defined settings at root Marker are copied to child Symbol Layer itemshttps://issues.qgis.org/issues/13033?journal_id=626432015-06-23T12:38:45ZNyall Dawson
<ul></ul><p>I originally thought the same (in fact, I got part way through coding it this way) but hit an issue.</p>
<p>Imagine the following situation. I want a marker symbol with three circle layers, one must always be 1mm diameter and the other two should have data defined size. If the data defined size was set and stored at the root level then there's no way to avoid the 1mm fixed size marker layer also changing size.</p>
<p>Perhaps my ideal implementation would be:<br />- data defined size stored at the root level. Data defined size is still set to a physical size (eg mm), but like the current implementation the individual layers are scaled depending on their relative sizes to the size set at the root level.<br />- a "lock value" option could be added to the data defined button to prevent the root data defined size from applying</p>
<p>That said, I think the only thing missing from the current implementation is that adding new layers should automatically have the dd size applied</p> QGIS Application - Bug report #13033: Data defined settings at root Marker are copied to child Symbol Layer itemshttps://issues.qgis.org/issues/13033?journal_id=626452015-06-23T23:07:06ZVincent Moravincent.mora@oslandia.com
<ul><li><strong>Affected QGIS version</strong> changed from <i>2.8.2</i> to <i>master</i></li></ul><p>Hi,</p>
<p>IMO if you are at the higher level, you want to control all thinks below, so I'm not fond of a lock below.</p>
<p>If you want to control the symbols sizes independently, you can still do that, we could add the assistant at the symbol level.</p>
<p>If I understand correctly, what you want is to be able to define the scale of several symbols, while defining the size differently for other symbols... sound like a list of makers to me.</p>
<p>For the ability to add new marker and change size, I think the solution is to reapply the marker DD expression (if its active) when something changes in the symbol list. Maybe also deactivating the corresponding DD buttons when a marker size, rotation or width is DD. I'm looking into that, but I can't find were to do it yet.</p> QGIS Application - Bug report #13033: Data defined settings at root Marker are copied to child Symbol Layer itemshttps://issues.qgis.org/issues/13033?journal_id=626462015-06-23T23:12:37ZNyall Dawson
<ul></ul><blockquote>
<p>If you want to control the symbols sizes independently, you can still do that, we could add the assistant at the symbol level</p>
</blockquote>
<p>It's already there ;) it was too nice a feature to not make wide use of, so I added it during the hackfest.</p> QGIS Application - Bug report #13033: Data defined settings at root Marker are copied to child Symbol Layer itemshttps://issues.qgis.org/issues/13033?journal_id=626662015-06-25T06:28:32ZVincent Moravincent.mora@oslandia.com
<ul><li><strong>Pull Request or Patch supplied</strong> changed from <i>No</i> to <i>Yes</i></li></ul><p>PR is here <a class="external" href="https://github.com/qgis/QGIS/pull/2166">https://github.com/qgis/QGIS/pull/2166</a></p> QGIS Application - Bug report #13033: Data defined settings at root Marker are copied to child Symbol Layer itemshttps://issues.qgis.org/issues/13033?journal_id=626672015-06-25T07:55:46ZVincent Moravincent.mora@oslandia.com
<ul></ul><p>And this one is to keep size/angle expressions when subsymbol changes <a class="external" href="https://github.com/qgis/QGIS/pull/2167">https://github.com/qgis/QGIS/pull/2167</a></p> QGIS Application - Bug report #13033: Data defined settings at root Marker are copied to child Symbol Layer itemshttps://issues.qgis.org/issues/13033?journal_id=626682015-06-25T15:59:05ZVincent Moravincent.mora@oslandia.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Fixed in changeset <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/cb104f0fcbd8e88356c2f8303748a1a525db6b15" title="set data-defined size,angle,width for added symbol fix #13033 When a symbol is added and the mark...">cb104f0fcbd8e88356c2f8303748a1a525db6b15</a>.</p>