https://issues.qgis.org/https://issues.qgis.org/favicon.ico2014-10-10T00:28:02ZQGIS Issue TrackingQGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=561502014-10-10T00:28:02ZFilipe Dias
<ul><li><strong>Operating System</strong> set to <i>Windows</i></li></ul><p>On Linux Ubuntu 14.04 it is in the right place.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=561732014-10-11T01:22:11ZPedro Venânciopedrongvenancio@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/download/7904/clean_button_xubuntu_12_04.png">clean_button_xubuntu_12_04.png</a> added</li></ul><p>On Linux Xubuntu 12.04 32bits (2.5.0+git20141010+738e0be~precise-ubuntugis1), I also get it in the wrong position.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=561742014-10-11T01:41:11ZFilipe Dias
<ul><li><strong>Operating System</strong> deleted (<del><i>Windows</i></del>)</li></ul> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=563882014-10-16T11:08:59ZSalvatore Larosalrssvtml@gmail.com
<ul><li><strong>Priority</strong> changed from <i>High</i> to <i>Severe/Regression</i></li><li><strong>Category</strong> changed from <i>Processing/GUI</i> to <i>GUI</i></li><li><strong>Assignee</strong> deleted (<del><i>Victor Olaya</i></del>)</li></ul><p>This seems to be a SIP python bindings problem, nothing to do with the processing framework.<br />Would be interesting to know if anybody gets the same behavior with a sip version > 4.13.3?</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=564862014-10-19T13:26:29ZJürgen Fischerjef@norbit.de
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=564912014-10-19T22:09:12ZMatthias Kuhn
<ul></ul><p>I have noticed similar effects for other widgets when the "customwidgets" library was not available on the system. I do not know if it is related.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565142014-10-20T01:59:25ZGiovanni Manghigiovanni.manghi@gmail.com
<ul></ul><p>Matthias Kuhn wrote:</p>
<blockquote>
<p>I have noticed similar effects for other widgets when the "customwidgets" library was not available on the system. I do not know if it is related.</p>
</blockquote>
<p>it is a recent dependency of python-qgis? Now that I notice this is installed and I cannot see anymore this issue.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565162014-10-20T02:24:48ZMatthias Kuhn
<ul></ul><p>Thank you for testing Giovanni.</p>
<p>It's not directly related to python. It's related to designer and promotion of widgets. I wonder if it shouldn't be a separate package but instead be installed automatically with the qgis packge (i.e. whenever the gui lib is installed).</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565262014-10-20T03:39:57ZSalvatore Larosalrssvtml@gmail.com
<ul></ul><p>Hi Matthias,<br />are you referred to -DWITH_CUSTOM_WIDGETS=ON cmake option?<br />If so, for me it has not worked.</p>
<p>I noticed the problem is that qt event (<code>resizeEvent()</code> and probably others) are not took into account from QgsFilterLineEdit class when initialized by python. Oddly, defining the protected function in SIP file does it work as expected.</p>
<p>I thought this could be a SIP version problem and I did ask for feedback with a different SIP version.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565392014-10-20T05:38:04ZMatthias Kuhn
<ul></ul><p>Hi Salvatore,</p>
<p>Yes, I was referring to this option, I am not sure if this issue is related.</p>
<p>Could you test PR 1654 to check if it solves this issue?</p>
<p>PS:<br />Not specifying overwritten virtuals can indeed be a problem AFAICT. Sip will have to create it's own overwritten method to allow overwriting it from within. In the default method it has to call the parent's overwritten method, which will then be QLineEdit::resizeEvent() instead of QgsFilterLineEdit::resizeEvent()</p>
<p><a class="external" href="https://github.com/qgis/QGIS/pull/1645">https://github.com/qgis/QGIS/pull/1645</a></p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565422014-10-20T06:01:17ZSalvatore Larosalrssvtml@gmail.com
<ul></ul><p>Hi Matthias, <br />maybe I have not explained well before, but adding protected functions is the workaround right now.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565462014-10-20T06:21:31ZMatthias Kuhn
<ul></ul><p>Hi Salvatore,</p>
<p>That's what the PR does. If you say it works, I can push it. And I would then not call it a workaround but rather a solution.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565482014-10-20T06:34:26ZSalvatore Larosalrssvtml@gmail.com
<ul></ul><p>Hi Matthias, <br />yes the PR works, and it is what I am trying to say since comment n.4 :)</p>
<p>I already had tried that, but I was not sure if adding protected methods to SIP files is corrected and I thought it could be a SIP version issue.</p>
<p>So your solution is perfect! :)</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565522014-10-20T06:55:08ZMatthias Kuhn
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li></ul><p>Fixed in changeset <a class="changeset" href="https://issues.qgis.org/projects/qgis/repository/revisions/4e8c679ba097f7f2c05e79945f9ba8475de1d49d" title="SIP update for QgsFilterLineEdit events have not been defined in the sip file, therefore QgsFilt...">4e8c679ba097f7f2c05e79945f9ba8475de1d49d</a>.</p> QGIS Application - Bug report #11372: Position of clean button in Processing search fieldhttps://issues.qgis.org/issues/11372?journal_id=565532014-10-20T07:08:51ZMatthias Kuhn
<ul></ul><p>Thank you for the feedback Salvatore, the SIP version confused me somehow and then I understood that customwidgets solve it for Giovanni, but good to have it solved now :)</p>
<p>(Packaging customwidgets along the gui libs may still be a good idea... We'll see if there are more issues concerning this)</p>