Add a Python repr for QgsError

qgis · Oct 23, 2018 · 4212cca · 4212cca
1 parent adec719
commit 4212cca
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/python/core/auto_generated/qgserror.sip.in b/python/core/auto_generated/qgserror.sip.in
@@ -126,6 +126,13 @@ messageList return the list of current error messages
 :return: current list of error messages
 %End
 
+
+    SIP_PYOBJECT __repr__();
+%MethodCode
+    QString str = QStringLiteral( "<QgsError: %1>" ).arg( sipCpp->message( QgsErrorMessage::Text ) );
+    sipRes = PyUnicode_FromString( str.toUtf8().constData() );
+%End
+
 };
 
 /************************************************************************

diff --git a/src/core/qgserror.h b/src/core/qgserror.h
@@ -132,6 +132,15 @@ class CORE_EXPORT QgsError
      */
     QList<QgsErrorMessage> messageList() const { return mMessageList; }
 
+
+#ifdef SIP_RUN
+    SIP_PYOBJECT __repr__();
+    % MethodCode
+    QString str = QStringLiteral( "<QgsError: %1>" ).arg( sipCpp->message( QgsErrorMessage::Text ) );
+    sipRes = PyUnicode_FromString( str.toUtf8().constData() );
+    % End
+#endif
+
   private:
     //! List of messages
     QList<QgsErrorMessage> mMessageList;

diff --git a/tests/src/python/test_python_repr.py b/tests/src/python/test_python_repr.py
@@ -17,7 +17,7 @@
 from PyQt5.QtCore import QVariant
 from qgis.testing import unittest, start_app
 from qgis.core import QgsGeometry, QgsPoint, QgsPointXY, QgsCircle, QgsCircularString, QgsCompoundCurve,\
-    QgsCurvePolygon, QgsEllipse, QgsLineString, QgsMultiCurve, QgsRectangle, QgsExpression, QgsField
+    QgsCurvePolygon, QgsEllipse, QgsLineString, QgsMultiCurve, QgsRectangle, QgsExpression, QgsField, QgsError
 
 start_app()
 
@@ -121,6 +121,10 @@ def testQgsFieldRepr(self):
         f = QgsField('field_name', QVariant.Double, 'double')
         self.assertEqual(f.__repr__(), "<QgsField: field_name (double)>")
 
+    def testQgsErrorRepr(self):
+        e = QgsError('you done wrong son', 'dad')
+        self.assertEqual(e.__repr__(), "<QgsError: dad you done wrong son>")
+
 
 if __name__ == "__main__":
     unittest.main()